8000 remove unused imports and variables by zacharyburnett · Pull Request #8651 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove unused imports and variables #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

remove unused imports and variables #8651

wants to merge 2 commits into from

Conversation

zacharyburnett
Copy link
Collaborator
@zacharyburnett zacharyburnett commented Jul 16, 2024 •
edited
Loading

apply Ruff rules F841 and F401 to the excluded modules jwst/fits_generator and jwst/associations

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Jul 16, 2024
@zacharyburnett zacharyburnett mentioned this pull request Jul 16, 2024
Merged
8 tasks
@codecov Codecov
Copy link
codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.59%. Comparing base (ccf871a) to head (3ac4be4).
Report is 9 commits behind head on master.

Files Patch % Lines
jwst/fits_generator/template.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8651      +/-   ##
==========================================
+ Coverage   59.56%   59.59%   +0.02%     
==========================================
  Files         391      391              
  Lines       39285    39267      -18     
==========================================
  Hits        23402    23402              
+ Misses      15883    15865      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator Author

this PR is superseded by #8652, unless we want to only apply the import-related fixes to these modules without un-excluding them

@emolter
Copy link
Collaborator
emolter commented Jul 17, 2024

I don't see anything wrong with un-excluding them and going with #8652

@zacharyburnett zacharyburnett deleted the lint/unused_imports branch July 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zacharyburnett zacharyburnett

Labels
associations fits_generator no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @emolter
0