Optimize images #2555
Merged
Optimize images #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 1,159.85kb -> 888.98kb (23.35%) /doc/parameters_recursion.png -- 20.01kb -> 10.60kb (47.03%) /doc/pa 8000 rameters_enum.png -- 13.44kb -> 7.22kb (46.28%) /doc/execution_model.png -- 20.74kb -> 11.88kb (42.73%) /doc/parameters_date_algebra.png -- 21.47kb -> 13.00kb (39.44%) /doc/tasks_with_dependencies.png -- 4.99kb -> 3.44kb (31.05%) /doc/task_parameters.png -- 6.05kb -> 4.29kb (29.06%) /luigi/static/visualiser/lib/jquery-ui/css/images/ui-icons_454545_256x240.png -- 6.83kb -> 4.86kb (28.86%) /luigi/static/visualiser/lib/jquery-ui/css/images/ui-icons_888888_256x240.png -- 6.83kb -> 4.86kb (28.86%) /doc/tasks_input_output_requires.png -- 15.51kb -> 11.10kb (28.45%) /luigi/static/visualiser/lib/jquery-ui/css/images/ui-icons_222222_256x240.png -- 6.76kb -> 4.85kb (28.2%) /doc/history_by_id.png -- 42.57kb -> 31.09kb (26.96%) /doc/web_server.png -- 130.79kb -> 97.25kb (25.65%) /doc/aggregate_artists.png -- 136.59kb -> 103.39kb (24.31%) /doc/user_recs.png -- 177.54kb -> 137.00kb (22.84%) /doc/history.png -- 40.09kb -> 31.41kb (21.65%) /doc/task_with_targets.png -- 7.86kb -> 6.17kb (21.51%) /doc/dependency_graph.png -- 127.42kb -> 100.24kb (21.33%) /doc/visualiser_front_page.png -- 127.86kb -> 102.44kb (19.89%) /doc/task_breakdown.png -- 179.64kb -> 144.92kb (19.33%) /doc/history_by_name.png -- 32.96kb -> 27.75kb (15.79%) /doc/luigi.png -- 25.00kb -> 22.41kb (10.35%) /luigi/static/visualiser/lib/jquery-ui/css/images/ui-icons_cd0a0a_256x240.png -- 4.44kb -> 4.40kb (0.86%) /luigi/static/visualiser/lib/jquery-ui/css/images/ui-icons_2e83ff_256x240.png -- 4.44kb -> 4.40kb (0.86%)
[ImgBot] optimizes images
New commits from Spotify:master
Tarrasch
approved these changes
Oct 20, 2018
|
Image quality has not been reduced, however in some cases it makes it
better!
|
|
Done! Thanks! |
|
:D Thanks for merging!! |
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Nov 19, 2018
* upstream-master: Make Worker parameter task_process_context an OptionalParameter (spotify#2468) (spotify#2574) Version 2.8.0 Implement configurable CORS. Add HdfsFlagTarget (spotify#2559) Fix HdfsAtomicWriteDirPipe.close() when using snakebite and the file do not exist. (spotify#2549) Small fix to logging in contrib/ecs.py (spotify#2556) [ImgBot] optimizes images (spotify#2555) Add CopyToTable task for MySQL (spotify#2553) Make capture_output non-positional in ExternalProgramTask (spotify#2547) Add Movio to list of Luigi users (spotify#2551) Interpolate environment variables in .cfg config files (spotify#2527) Fix ReadTheDocs build (spotify#2546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have optimized all the images in the repository (file size decreased)
Motivation and Context
I did this because I love both Spotify and open-source
Have you tested this? If so, how?
Should work fine, Travis CI build is passing.