Add HdfsFlagTarget #2559
Merged
Add HdfsFlagTarget #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update current fork of Luigi
|
Could you merge master for the flake8 fix? (it was recently merged) |
dlstadther
reviewed
Oct 28, 2018
test/contrib/hdfs_test.py
Outdated
| @@ -386,6 +386,12 @@ def create_target(self, format=None): | |||
| target.remove(skip_trash=True) | |||
| return target | |||
|
|
|||
| def create_flag_target(self, format=None): | |||
There was a problem hiding this comment.
the method name here is confusing. You aren't actually creating the flag target. Just the class object needed to later create the flag
There was a problem hiding this comment.
I'm not sure what you mean here, this method does create a HdfsFlagTarget, and the helper method is modeled off of the similar method called create_target line 385.
But in any case I don't think the helper method is necessary (especially if only used in that once test) and can be removed and the FlagTarget created in the test
dlstadther
approved these changes
Oct 29, 2018
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Nov 19, 2018
* upstream-master: Make Worker parameter task_process_context an OptionalParameter (spotify#2468) (spotify#2574) Version 2.8.0 Implement configurable CORS. Add HdfsFlagTarget (spotify#2559) Fix HdfsAtomicWriteDirPipe.close() when using snakebite and the file do not exist. (spotify#2549) Small fix to logging in contrib/ecs.py (spotify#2556) [ImgBot] optimizes images (spotify#2555) Add CopyToTable task for MySQL (spotify#2553) Make capture_output non-positional in ExternalProgramTask (spotify#2547) Add Movio to list of Luigi users (spotify#2551) Interpolate environment variables in .cfg config files (spotify#2527) Fix ReadTheDocs build (spotify#2546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an
HdfsFlagTargetmodeled off the classS3FlagTargethttps://github.com/spotify/luigi/blob/master/luigi/contrib/s3.py#L680Motivation and Context
The problem this solves is the same as the
S3FlagTarget. We'll havesparkjobs output to directories and use the_SUCCESSsemaphore to check for job completion.Have you tested this? If so, how?
This is a fix we've used for a pipeline, and it runs 😸 . It is also nearly identical to the
S3FlagTarget, which also works. I included unit tests.