8000 fixing regex issue where . were not allowed in endpoint path (#305) by sbabayan · Pull Request #306 · tableau/TabPy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixing regex issue where . were not allowed in endpoint path (#305) #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

fixing regex issue where . were not allowed in endpoint path (#305) #306

merged 1 commit into from
May 30, 2019

Conversation

sbabayan
Copy link
Contributor

merging fix into dev

@WillAyd
Copy link
Contributor
WillAyd commented May 30, 2019

Gotcha. Wouldn’t this work without the backslash though?

@jnegara
Copy link
Contributor
jnegara commented May 30, 2019

Haha maybe. I'm not really good at regex, but it seems to work when I test it. @0golovatyi thoughts?

@0golovatyi 0golovatyi merged commit fb581bf into dev May 30, 2019
@jnegara jnegara mentioned this pull request May 30, 2019
Closed
0golovatyi added a commit that referenced this pull request Jul 31, 2019
@0golovatyi
Migrate to Tornado 6 and other improvements (#329)
c856ab9 
* Added parameter for configuring timeout for /evaluate. (#298)

* Added configurable timeout.

* Added unit test for custom evaluate timeout.

* Fixed evaluation timeout, added integration tests + additional UT.

* Documentation updates.

* Reverting state.ini.

* Updated file path in server-config.md.

* Fixing pep8 issues.

* Improved timeout error messaging.

* Fixed docs, removed debugging prints.

* Returning HTTP code 408 on eval timeout.

* Querying models through /evaluate causes server hang. (#300)

* Made call_subprocess non-blocking.

* Magic?

* Using native coroutines in EvaluationPlaneHandler.

* Updated docs to reflect timeout limitations.

* Resolved markdownlint issue.

* Back to tornado coroutines.

* Fixed pep8 style.

* fixing regex issue where . were not allowed in endpoint path (#305) (#306)

* adding t-test to pre-deployed models (#312)

* adding t-test to pre-deployed models

* fixed pep8 issues

* import error on ttest and updated successful deployment message for sentiment analysis

* fixed md issues

* fixed endpoint name in integration tests

* refactor redundant code and update md

* Add FAQ.md (#325)

* Update README.md

* Create FAQ.md

* Fix models call via /evaluate in HTTPS (#322)

* Fix models call via /evaluate in HTTPS

* Restore state.ini

* Delete 'Supported Configurations' page (#327)

* Upgrade to Tornado 6 (#328)

* remove asyncronous attribute for coroutines

* Remove dependency on jsonschema

* Fix markdown

* Update setup.py

* Add tornado to travis script

* Add tornado to travis script

* Remove tornado-json dependency

* Update VERSION

* Update CHANGELOG

* Fix pycodestyle warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@jnegara jnegara jnegara approved these changes

@0golovatyi 0golovatyi 0golovatyi approved these changes

Assignees
No one assigned
Labels
bug
< 47BD div class="discussion-sidebar-heading text-bold"> Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbabayan @WillAyd @jnegara @0golovatyi @nmannheimer
0