Migrate to Tornado 6 and other improvements #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added configurable timeout. * Added unit test for custom evaluate timeout. * Fixed evaluation timeout, added integration tests + additional UT. * Documentation updates. * Reverting state.ini. * Updated file path in server-config.md. * Fixing pep8 issues. * Improved timeout error messaging. * Fixed docs, removed debugging prints. * Returning HTTP code 408 on eval timeout.
* Made call_subprocess non-blocking. * Magic? * Using native coroutines in EvaluationPlaneHandler. * Updated docs to reflect timeout limitations. * Resolved markdownlint issue. * Back to tornado coroutines. * Fixed pep8 style.
Bringing overwritten test into dev
* adding t-test to pre-deployed models * fixed pep8 issues * import error on ttest and updated successful deployment message for sentiment analysis * fixed md issues * fixed endpoint name in integration tests * refactor redundant code and update md
* Update README.md * Create FAQ.md
* Fix models call via /evaluate in HTTPS * Restore state.ini
* remove asyncronous attribute for coroutines * Remove dependency on jsonschema * Fix markdown * Update setup.py * Add tornado to travis script * Add tornado to travis script * Remove tornado-json dependency * Update VERSION * Update CHANGELOG
|
Hello @0golovatyi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-07-31 18:20:52 UTC |
added 2 commits
July 31, 2019 11:15
sbabayan
approved these changes
Jul 31, 2019
jnegara
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
file option