Convert unit tests from CppUnit to Catch. #825
Conversation
|
I'd like to go ahead with this. Are there any major objections? |
2948ed7 to
de25bc6
Compare
|
Hey, no biggy, but I was just peeking my head into the taglib repo here and noticed that this pull request seems not to have gone through, but that it looks like it was meant to? —And maybe this is overthinking things, or bikeshedding, or whatever, but doctest is a similar unit test library to Catch, but much faster (according to their github page, at least). I think it may even be very nearly directly compatible with Catch—I seem to recall it actually originating as a fork of Catch. Maybe I'd try offering a pull request myself, but again, maybe such a thing is too “bikeshed-y”, especially with this pull request apparently not having gone through. |
|
gtest might be better. catch2 recently decided to break compatibility while retaining the catch2 name. |
|
@TsudaKageyu can you rebase this? |
|
Alright so CMake doesn't do subprojects which makes using Catch2 difficult. That is, OS provided Catch2. Catch2 itself really shouldn't be included here. OS wise, Catch2 is all over the place. Older Debian/Ubuntu have only Catch1. Newer have Catch2 v2 and no v3. Others only have v3. gtest is much better OS wise. But it is more verbose than Catch2. |
As I mentioned in #822, CppUnit haven't been able to catch up the latest compilers. It requires a workaround to work with the latest AppleClang. (See 6000a19)
So I'd like to suggest that we change our unit test framework from CppUnit to Catch, one of the up-to-date and well-maintained unit test frameworks.
Catch is a single-header library maintained on GitHub. I find it really handy especially on Windows/MSVC since it doesn't require any preparation like building libs, adding paths and blah blah blah. Of course, it works fine on Linux or OSX without any external dependencies.