8000 tests: switch to GTest by neheb · Pull Request #1124 · taglib/taglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests: switch to GTest #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

tests: switch to GTest #1124

wants to merge 3 commits into from

Conversation

neheb
Copy link
Contributor
@neheb neheb commented Aug 24, 2023

GTest seems to be better maintained and has more features.

Most of this commit was done with sed and clang-format.

Replacement for: #825

@neheb neheb force-pushed the gt branch 3 times, most recently from 2f45d86 to b6f81e3 Compare August 24, 2023 02:46
@neheb
Copy link
Contributor Author
neheb commented Aug 24, 2023

Interesting that I cannot reproduce this locally. Even with containers.

@neheb neheb force-pushed the gt branch 4 times, most recently from 379720a to ca8d0ad Compare August 24, 2023 20:09
@neheb
Copy link
Contributor Author
neheb commented Aug 24, 2023

google/googletest#4079

agh.

@ufleisch
Copy link
Contributor

According to google/googletest#3552 (comment), this will probably never be fixed for GCC 11.

@neheb
Copy link
Contributor Author
neheb commented Aug 31, 2023

Guess I'll abandon this. Oh well.

@neheb neheb force-pushed the gt branch 2 times, most recently from a7a5afe to a892b3b Compare September 7, 2023 00:25
GTest seems to be better maintained and has more features.

Most of this commit was done with sed and clang-format.
@neheb
Copy link
Contributor Author
neheb commented Sep 7, 2023

Maybe the overall solution is to mandate a more recent version of gtest. Maybe implement as a git subpproject.

@neheb neheb force-pushed the gt branch 5 times, most recently from 9197b19 to 88deb13 Compare September 7, 2023 05:25
gtest as of version 1.11 makes GCC exhibit an ADL bug that was only
fixed in version 1.14. Use the gtest subproject in such a case.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ufleisch
Copy link
Contributor
ufleisch commented Sep 8, 2023

The initial intention was to provide something which "is better maintained and has more features" than CppUnit. However, if I look at the current situation with the incompatibility with GCC 11 and that this will probably not be fixed, I fear that switching from CppUnit to GTest will cause more pain than joy to the users of TagLib. After all, they have successfully set up CppUnit, and it is working quite well. The additional features of GTest, e.g. GMock, may be nice, but I do not see that we need them for TagLib. So I would suggest that we stick with CppUnit for now.

@neheb
Copy link
Contributor Author
neheb commented Sep 8, 2023

Catch2 could be an alternative. Although version 3 is completely incompatible with 2. Weird choice by upstream.

@ufleisch
Copy link
Contributor
ufleisch commented Sep 9, 2023

The important thing for version 2.0.0 is to come up with a stable API, so that later versions can remain binary compatible. I there is really a need to replace the unit testing framework, this could be done later (e.g. when nobody is using a combination of compiler and unit testing framework which is not working). So I would suggest that we put our energy in the things which have to be ready with the release of version 2.0.0. What could be helpful is if you could publish your scripts which can migrate the test cases using sed and clang-format 8000 .

@neheb
Copy link
Contributor Author
neheb commented Sep 9, 2023

I think I posted the clang-format script once. There was no interest. The sed stuff is very unpolished and still manual.

@neheb neheb closed this Dec 14, 2023
@neheb neheb deleted the gt branch December 14, 2023 04:22
@neheb neheb restored the gt branch December 14, 2023 04:22
@neheb neheb deleted the gt branch December 14, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0