Convert IPLS to TIPL and TMCL (#1274) #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The involvement/involvee pairs which are supported for TIPL properties (ARRANGER, ENGINEER, PRODUCER, DJ-MIX, MIX) are left in the TIPL frame, other pairs are moved to a TMCL frame. This will result in a consistent behavior for both ID3v2.3 and ID3v2.4 tags produced by MusicBrainz Picard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The involvement/involvee pairs which are supported for TIPL properties (ARRANGER, ENGINEER, PRODUCER, DJ-MIX, MIX) are left in the TIPL frame, other pairs are moved to a TMCL frame. This will result in a consistent behavior for both ID3v2.3 and ID3v2.4 tags produced by MusicBrainz Picard.
This will improve compatibility of the property map interface with files tagged by MusicBrainz Picard. Two problems are addressed:
With these changes, running examples/tagreader on the example file from #1274 will contain the missing properties:
The file has an IPLS frame containing "guitar|George Harrison|guitar|John Lennon|guitar|Paul McCartney|bass|Paul McCartney|drums (drum set)|Ringo Starr|French horn|James W. Buck|French horn|John Burden|French horn|Neill Sanders|French horn|Tony Randall|mix|Giles Martin|background vocals|George Harrison|background vocals|John Lennon|background vocals|Paul McCartney|lead vocals|Paul McCartney", the "mix" involvement is the "MIXER" property, all other involvements are "PERFORMER:" properties.