8000 Fix printing of auto-selected GPU free memory by talmo · Pull Request #955 · talmolab/sleap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix printing of auto-selected GPU free memory #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

talmo
Copy link
Collaborator
@talmo talmo commented Sep 14, 2022

Description

Small fix: we're currently printing the free memory for all GPUs, not just the selected one.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@talmo talmo marked this pull request as ready for review September 14, 2022 23:32
@codecov
Copy link
codecov bot commented Sep 14, 2022

Codecov Report

Merging #955 (5b36b24) into develop (e919f36) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #955      +/-   ##
===========================================
- Coverage    67.57%   67.56%   -0.01%     
===========================================
  Files          130      130              
  Lines        22240    22242       +2     
===========================================
  Hits         15028    15028              
- Misses        7212     7214       +2     
Impacted Files Coverage Δ
sleap/nn/inference.py 78.99% <0.00%> (-0.07%) ⬇️
sleap/nn/training.py 59.50% <0.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@talmo talmo merged commit bfcc1f4 into develop Sep 15, 2022
@talmo talmo deleted the talmo/fix-gpu-free-mem-printing branch September 15, 2022 00:08
talmo added a commit that referenced this pull request Oct 10, 2022
* Fix printing of auto-selected GPU free memory (#955)

* Fix printing of auto-selected GPU free memory

* Fix printing in inference

* Lint

* Fix add suggestions when target is current video (#956)

* Fix export cli arg parsing (#962)

* Fix cattr in Python 3.9 (#967)

* Remove structuring hook for forward reference and handle manually

* Handle missing key

* Add sample movies to docs (#992)

* Add initial examples

* Add clips for all datasets

* Add quick example clip

* Typo on instance count for flies13

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
Co-authored-by: sheridana <asheridan@salk.edu>
@roomrys roomrys mentioned this pull request Nov 11, 2022
roomrys added a commit that referenced this pull request Nov 11, 2022
Docs update (#993)

* Fix printing of auto-selected GPU free memory (#955)

* Fix printing of auto-selected GPU free memory

* Fix printing in inference

* Lint

* Fix add suggestions when target is current video (#956)

* Fix export cli arg parsing (#962)

* Fix cattr in Python 3.9 (#967)

* Remove structuring hook for forward reference and handle manually

* Handle missing key

* Add sample movies to docs (#992)

* Add initial examples

* Add clips for all datasets

* Add quick example clip

* Typo on instance count for flies13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0