10000 Fix export cli arg parsing by sheridana · Pull Request #962 · talmolab/sleap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix export cli arg parsing #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix export cli arg parsing #962

merged 1 commit into from
Sep 16, 2022

Conversation

sheridana
Copy link
Contributor

Description

Parser expects dot notation to avoid NameSpace error.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@sheridana sheridana requested a review from talmo September 16, 2022 17:49
@codecov
Copy link
codecov bot commented Sep 16, 2022

Codecov Report

Merging #962 (1442ba7) into develop (c1c5b2d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #962   +/-   ##
========================================
  Coverage    67.55%   67.55%           
========================================
  Files          130      130           
  Lines        22246    22246           
========================================
  Hits         15028    15028           
  Misses        7218     7218           
Impacted Files Coverage Δ
sleap/nn/inference.py 78.99% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sheridana sheridana marked this pull request as ready for review September 16, 2022 18:27
@talmo talmo merged commit be89412 into develop Sep 16, 2022
@talmo talmo deleted the arlo/bonsai_fix branch September 16, 2022 22:17
talmo added a commit that referenced this pull request Oct 10, 2022
* Fix printing of auto-selected GPU free memory (#955)

* Fix printing of auto-selected GPU free memory

* Fix printing in inference

* Lint

* Fix add suggestions when target is current video (#956)

* Fix export cli arg parsing (#962)

* Fix cattr in Python 3.9 (#967)

* Remove structuring hook for forward reference and handle manually

* Handle missing key

* Add sample movies to docs (#992)

* Add initial examples

* Add clips for all datasets

* Add quick example clip

* Typo on instance count for flies13

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
Co-authored-by: sheridana <asheridan@salk.edu>
roomrys added a commit that referenced this pull request Nov 11, 2022
Docs update (#993)

* Fix printing of auto-selected GPU free memory (#955)

* Fix printing of auto-selected GPU free memory

* Fix printing in inference

* Lint

* Fix add suggestions when target is current video (#956)

* Fix export cli arg parsing (#962)

* Fix cattr in Python 3.9 (#967)

* Remove structuring hook for forward reference and handle manually

* Handle missing key

* Add sample movies to docs (#992)

* Add initial examples

* Add clips for all datasets

* Add quick example clip

* Typo on instance count for flies13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0