Redesign user page (#1250) #1282
Conversation
* Added PresenceLabel widget as a status indicator based on status widget on profile page * Move GapopaID to a copyable text field * Remove the 'More' button * Add action buttons: Add Favorite, Mute, Clear Chat, Delete Chat * Implemented tests for actions added by buttons Additionally: * added factory constructor to ReactiveTextField for copyable variant based on GapopaID ReactiveTextField on profile page * refactor the 'Clear Chat' test
FCM |
* added Key? key parameter to ReactiveTextField factory constructor * delete unnecessary Obx around action buttons * added missing keys to: gapopaId text field and presence label
|
@GennadiyMurzhi, also be sure to fix the FCM please - it doesn't follow Development Workflow currently. |
- sort imports in profile page - remove unnecessary padding parameter from ActionButton - replace padding inside ActionButton implementation - remove unused class from _Constants in UserView file - remove user fetching when muting chat in UserController - remove separate chat fetching in UserController - fix 'unfavorites' to 'favorites' in unfavoriteChat method documentation - fix padding in AppBar in ChatView as dialog - format ChatView file under 80-characters-or-fewer - restore line break before TODO comment about contacts in ChatView - remove unnecessary ReactiveTextField.copyable formatter - make presence field optional in PresenceLabel - remove article 'A' from PresenceLabel documentation - replace step name in B2B 'Clear chat' test - fix 'User is in dialog chat with Bob' test step name - add line break to 'Dialog muting and unmuting' test file
|
All review points have been fixed, including FCM. @SleepySquash, please review again. |
|
@GennadiyMurzhi, use the |
Sorry, yes of course. I’ll run 'dartanalyze' and then click the 'Re-request review' button. |
There was a problem hiding this comment.
@GennadiyMurzhi, I have a few recommendations.
Please, read thoughtfully your code. Line after line, ask yourself with each change the questions like "Is this change necessary?", "Didn't I break some rules by doing so?", "Should really this line be added/removed?", "Will other people understand what I did there?", etc. You should be really sure with the code you're sending for a PR. If there's something you ain't sure about, look at the examples. For example, you can compare your FCM against any FCMs in the repository - project has 700+ already merged PRs, each one having the proper FCM. The same goes for the code. If code is in main branch, then it was read and approved, look at the code and compare it against yours. And the guidelines - don't forget about those.
Also note that any comment that are left during PR aren't specifically about the place that was mentioned - the comments cover all the mistakes or observations regarding the specified kind of behaviour. For example, if there's a comment with a request to follow the Contribution Guideline, then you should follow it everywhere, not just in the place that was pointed by the comment. Each comment should be kept in your memory so that you don't repeat the same mistakes again.
|
Oopsie, wrong PR. Sorry for that. |
…s and update e2e tests
- use SizedBox instead of padding in ChatView during Dialog mode
- check imports order
- fix documentation for favoriteChat and unfavoriteChat methods in UserController
- fix error messages in UserController methods: favoriteChat, unfavoriteChat, muteChat, unmuteChat, hideChat, clearChat
- change icon size and add icon svg for action buttons in UserView
- replace {string} with {TestUser} in steps where users should be used
- remove unnecessary platform check in MuteButton
- update documentation for unmuteChat method according to DartEffective
- check all files for correct imports order
- fix error handling in UserController unblock method
- unify e2e test keys in keys.dart by replacing multiple keys with: ClearButton, DeleteButton, FavoriteButton, MuteButton
- `delete19` replaced by `delete19v2` in svgs icons - fix e2e keys
Resolves Redesign User page #1250
Synopsis
Page should be redesigned.
Solution
This PR updates the design of the User Page. The TextField for Gapopa ID and the presence status widget are now provided by the Profile Page and made reusable. The "More" button in the App Bar has been removed. Action buttons have been added along with B2B tests for their actions: Add Favorite, Mute, Clear Chat, and Delete Chat.
Checklist
k::labels applied