Add include_deleted filter to ListNamespace API #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22b204c to
bee114a
Compare
yiminc
approved these changes
Mar 25, 2022
| message NamespaceFilter { | ||
| // By default namespaces in NAMESPACE_STATE_DELETED are not included. | ||
| // Setting include_deleted to true will include deleted namespaces. | ||
| // Note: Namespace is in NAMESPACE_STATE_DELETED state when it was deleted from the system but associated is not deleted yet. |
There was a problem hiding this comment.
associated workflow executions is not deleted yet.
There was a problem hiding this comment.
it should say "data". I missed the word for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add
include_deletedfilter toListNamespaceAPI.Why?
To be able to include deleted namespaces in response.
How did you test it?
N/A
Potential risks
No risks.