Exclude deleted namespaces from ListNamespace response #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Mar 25, 2022
| // do not include the metadata record | ||
| if name != namespaceMetadataRecordName { | ||
| // do not include the metadata record | ||
| if name == namespaceMetadataRecordName { |
There was a problem hiding this comment.
This file changes are not related to deleted namespace but it had the same problem (essentially bug). If there was namespaceMetadataRecordName record in response, results might have fewer items than defined by pageSize. It is easy testable if pageSize set to 1. Previous implementation just returned empty page in the middle of pagination.
yiminc
approved these changes
Mar 25, 2022
| if skippedRows == 0 { | ||
| break | ||
| } | ||
| pageSize = skippedRows |
2e18547 to
5fc0a5f
Compare
|
API changes is here: temporalio/api#167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Exclude deleted namespaces from
ListNamespaceresponse.Why?
By default deleted namespaces (which exist in database during reclaim resources step) should not be returned by
ListNamespaceAPI.How did you test it?
New unit tests.
Potential risks
No risks.
Is hotfix candidate?
No.