8000 Allow updating particular branches by feedmeapples · Pull Request #23 · temporalio/docker-builds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow updating particular branches #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 16, 2022
Merged

Allow updating particular branches #23

merged 4 commits into from
Feb 16, 2022

Conversation

feedmeapples
Copy link
Contributor
@feedmeapples feedmeapples commented Feb 15, 2022 •
edited
Loading

What was changed

  • Starts accepting Submodule name and Branch as the inputs (ex. temporal)
  • Checks out and updates the submodule for a given branch (ex. v1.1.0)
  • Commits the changes into a branch with the same name

Why?

Automating patch releases

Checklist

  1. Closes

  2. How was this tested:

Tested the code with personal repos and simulating the changes:
https://github.com/feedmeapples/gha-parent
https://github.com/feedmeapples/gha-child

  1. Any docs updates needed?

This was referenced Feb 15, 2022
Merged
Merged
dnr
dnr reviewed Feb 15, 2022
View reviewed changes
Copy link
Member
@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this strategy works alright if one submodule has release branches (in this case it would be temporal). On each release branch it'll start from the tctl main branch at the point where that release branch was created, and then never update it along that branch. It'll be a big pain if we need to patch tctl on multiple release branches, but I guess we can hope we never have to do that.

@feedmeapples feedmeapples requested a review from dnr February 15, 2022 21:32
dnr
dnr reviewed Feb 15, 2022
View reviewed changes
Copy link
Member
@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this doesn't actually build images for the release branch commits yet, right? Is that going to come in another PR?

@feedmeapples feedmeapples requested a review from dnr February 15, 2022 23:17
@feedmeapples feedmeapples merged commit 8b0c93b into main Feb 16, 2022
@feedmeapples feedmeapples deleted the update-branches branch February 16, 2022 03:27
feedmeapples added a commit that referenced this pull request Feb 16, 2022
@feedmeapples
Allow updating particular branches (#23)
316c85b 
* Allow updating particular branches

* address comments

* address comments

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @dnr
0