8000 Trigger Docker builds on release branches by feedmeapples · Pull Request #2510 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trigger Docker builds on release branches #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2022
Merged

Trigger Docker builds on release branches #2510

merged 3 commits into from
Feb 16, 2022

Conversation

feedmeapples
Copy link
Contributor
@feedmeapples feedmeapples commented Feb 15, 2022 •
edited
Loading

What changed?

Starts Triggering Docker builds on commits into Release branches

Related PR:
temporalio/docker-builds#23

Why?

Automating releases

How did you test it?

Tested the code with personal repos and simulating the changes:
https://github.com/feedmeapples/gha-parent
https://github.com/feedmeapples/gha-child

Potential risks

Is hotfix candidate?

@feedmeapples feedmeapples requested a review from a team as a code owner February 15, 2022 05:32
@feedmeapples feedmeapples force-pushed the build-docker-release-branches branch from bfa96aa to 894a1e7 Compare February 15, 2022 05:33
dnr
dnr reviewed Feb 15, 2022
View reviewed changes
.github/workflows/trigger-publish.yml Outdated
@@ -4,6 +4,7 @@ on:
push:
branches:
- master
- release/v[0-9]+.[0-9]+.[0-9]+ # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, this doesn't match any current release branches (which are named like release/v1.14.x).

Second, how about just make it release/*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, yea let's just make * then

@feedmeapples feedmeapples force-pushed the build-docker-release-branches branch from c5f58c6 to ef9f14e Compare February 15, 2022 19:56
@feedmeapples feedmeapples requested a review from dnr February 15, 2022 19:57
dnr
dnr reviewed Feb 15, 2022
View reviewed changes
.github/workflows/trigger-publish.yml Outdated
@@ -4,6 +4,7 @@ on:
push:
branches:
- master
- release/*
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, why do we need workflow_dispatch here? what calls this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@feedmeapples feedmeapples merged commit 615fb91 into master Feb 16, 2022
@feedmeapples feedmeapples deleted the build-docker-release-branches branch February 16, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr approved these changes

@yiminc yiminc yiminc approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feedmeapples @dnr @yiminc
0