8000 [WIP] DESC integration by LuckyMD · Pull Request #131 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] DESC integration #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 3, 2020
Merged

[WIP] DESC integration #131

merged 10 commits into from
Aug 3, 2020

Conversation

LuckyMD
Copy link
Collaborator
@LuckyMD LuckyMD commented Jul 29, 2020 •
edited
Loading

This PR adds DESC into the benchmarking setup.

This method requires the following packages to be installed:
pip install desc==2.0.3 pydot
conda install GraphViz

This is still work in progress. These steps have been taken:

  • Add DESC function to scIB
  • Test DESC function in notebook
  • Test DESC in the Snakemake setup
  • Write a test for DESC (optional)

@LuckyMD LuckyMD requested a review from danielStrobl July 29, 2020 13:48
@LuckyMD
Copy link
Collaborator Author
LuckyMD commented Jul 29, 2020

@eleozzr Could you check if this function matches how you would use DESC?

@LuckyMD LuckyMD mentioned this pull request Jul 30, 2020
Open
@LuckyMD
Copy link
Collaborator Author
LuckyMD commented Aug 3, 2020

I think this is about ready, @danielStrobl can you review in case there's sth you can find?

danielStrobl
danielStrobl approved these changes Aug 3, 2020
View reviewed changes
@LuckyMD
Copy link
Collaborator Author
LuckyMD commented Aug 3, 2020 •
edited
Loading

To do:

  • final snakemake test

@LuckyMD LuckyMD merged commit 989158c into master Aug 3, 2020
@LuckyMD LuckyMD deleted the desc branch August 3, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielStrobl danielStrobl danielStrobl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuckyMD @danielStrobl
0