8000 Update scIB-python.yml by danielStrobl · Pull Request #147 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update scIB-python.yml #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 9, 2021
Merged

Update scIB-python.yml #147

merged 12 commits into from
Feb 9, 2021

Conversation

danielStrobl
Copy link
Member

Updated the python env

@danielStrobl
Update scIB-python.yml
3d4fcb1 
Updated the python env
@danielStrobl danielStrobl requested a review from LuckyMD August 27, 2020 13:16
LuckyMD
LuckyMD requested changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to add version numbers to some tools

@LuckyMD
Copy link
Collaborator
LuckyMD commented Aug 28, 2020

@danielStrobl There doesn't seem to be any kBet in here...

lazappi
lazappi reviewed Sep 10, 2020
View reviewed changes
@lazappi
Copy link
Member
lazappi commented Sep 10, 2020

There are also a couple of things that are linux specific and need to be removed to install on MacOS

This was referenced Sep 23, 2020
Closed
Closed
@deevdevil88 deevdevil88 mentioned this pull request Sep 29, 2020
Closed
@LuckyMD LuckyMD mentioned this pull request Dec 15, 2020
Merged
@danielStrobl
Copy link
Member Author

This should be merge ready now. Tested on my local machine. Also, manually setting the .libPaths() is not necessary anymore due to the inclusion of r-environment which seems to do this automatically

@danielStrobl danielStrobl requested a review from LuckyMD December 22, 2020 11:50
LuckyMD
LuckyMD requested changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few package version questions still. @lazappi and @mumichae you guys both tried to install this env. Anything missing here from your sides?

@LuckyMD
Copy link
Collaborator
LuckyMD commented Jan 4, 2021

Also, manually setting the .libPaths() is not necessary anymore due to the inclusion of r-environment which seems to do this automatically

That's very cool!

@lazappi
Copy link
Member
lazappi commented Jan 7, 2021

A few package version questions still. @lazappi and @mumichae you guys both tried to install this env. Anything missing here from your sides?

I've forgotten all the issues I ran into. I think I gave @danielStrobl a list at some point, if those have been addressed probably good from my side.

LuckyMD
LuckyMD requested changes Jan 15, 2021
View reviewed changes
@mumichae mumichae mentioned this pull request Jan 30, 2021
Closed
@danielStrobl
Copy link
Member Author

I tested to install the env with the recent changes on my local machine, the installation ran through without errors and pip check also doesn't return errors after installation.

LuckyMD
LuckyMD requested changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small changes, then it's good to go @mumichae

@LuckyMD LuckyMD merged commit d03f6cf into master Feb 9, 2021
@LuckyMD LuckyMD deleted the danielStrobl-patch-1 branch February 9, 2021 17:35
@LuckyMD
Copy link
Collaborator
LuckyMD commented Feb 9, 2021

Well done @mumichae and @danielStrobl! Great to finally have this merged!

@mumichae mumichae mentioned this pull request Feb 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazappi lazappi lazappi left review comments

@mumichae mumichae mumichae left review comments

@LuckyMD LuckyMD LuckyMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielStrobl @LuckyMD @lazappi @mumichae
0