Fix finding optimal resolution for clustering #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyMD
approved these changes
Oct 4, 2020
|
This is very problematic... We need to redo the NMI and ARI metrics for all benchmarking results... @danielStrobl do you have any idea how long it would take to only run the NMI and ARI metrics again? @mumichae could you write a script to only run the NMI and ARI metrics again and update the metrics outputs in the relevant files? |
|
Yes, I'll look into it tomorrow. If we only redo the 2 scores, it should be very fast, most time is spent on the preprocessing and other metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Clustering does not use optimised resolution but last resolution of search space.
Solution: Corrected typo that broke finding optimal score for clustering.
This affects all metrics and other operations reliant on optimised clustering. If we have conclusions based on the clustering-based metrics, we might want to re-evaluate the metrics with this bugfix, if it is still feasible.