8000 Include LISI files during package installation by mumichae · Pull Request #186 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include LISI files during package installation #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Conversation

mumichae
Copy link
Collaborator
@mumichae mumichae commented Oct 5, 2020

LISI files are not being copied during pip installation of scIB. By specifying the missing files in the setup.py, they will be copied. However, that does not mean that the C source code is recompiled.

@mumichae mumichae requested a review from LuckyMD October 5, 2020 10:32
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! Thanks a lot!

@LuckyMD
Copy link
Collaborator
LuckyMD commented Oct 5, 2020

If we at some point figure out we can make the files be recompiled as well if we install via pip that would be amazing... but i guess this might not be possible.

@LuckyMD LuckyMD merged commit 1748648 into master Oct 5, 2020
@LuckyMD LuckyMD deleted the install_lisi branch October 5, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0