8000 change adata to adata_tmp in LISI_graph by mbuttner · Pull Request #201 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

change adata to adata_tmp in LISI_graph #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

change adata to adata_tmp in LISI_graph #201

merged 1 commit into from
Oct 30, 2020

Conversation

mbuttner
Copy link
Contributor

No description provided.

@mbuttner mbuttner requested a review from LuckyMD October 30, 2020 13:32
@LuckyMD
Copy link
Collaborator
LuckyMD commented Oct 30, 2020

Can we test on snakemake using only pancreas (but all metrics) to see if this changes lisi scores?

@LuckyMD LuckyMD requested a review from danielStrobl October 30, 2020 13:58
LuckyMD
LuckyMD approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple fix, just requires testing if this addresses the bug we found.

@danielStrobl
Copy link
Member

Screenshot from 2020-10-30 17-31-52
Seems like this doesn't affect our scores, so we don't need to rerun.

@LuckyMD
Copy link
Collaborator
LuckyMD commented Oct 30, 2020

Nice! So this is probably only an issue for subsetted objects then @Hrovatin! We will merge but will then not rerun fully.

@LuckyMD LuckyMD merged commit fe698b9 into master Oct 30, 2020
@LuckyMD LuckyMD deleted the fix_lisi_neighbors branch October 30, 2020 16:45
@LuckyMD LuckyMD mentioned this pull request Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckyMD LuckyMD LuckyMD approved these changes

@danielStrobl danielStrobl danielStrobl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbuttner @LuckyMD @danielStrobl
0