Isolated label asw embed #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er positional for silhouette functions
LuckyMD
requested changes
Feb 16, 2021
There was a problem hiding this comment.
A few changes:
- wording "default" instead of "usually"
- Clean up order of parameters in function call to silhouette_batch
- function description of score_isolated_label
- Cluster_key is now always set to overwrite
adata.obs['iso_label']. That's probably fine as this was done in the pipeline anyway. Not really an issue...
LuckyMD
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
isolated_label()metric did not allow to specify which embedding to use, and usesX_pcainstead.Solutions
embedoption toisolated_labelfunctionembedinsilhouette()as a positional parameteruse_repparameter foropt_louvain()