8000 Check dependies in functions by mumichae · Pull Request #262 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check dependies in functions #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 17, 2021
Merged

Check dependies in functions #262

merged 7 commits into from
Sep 17, 2021

Conversation

mumichae
Copy link
Collaborator
@mumichae mumichae commented Sep 16, 2021 •
edited
Loading

Check if optional dependencies are available in their respective functions and control behaviour when import fails.

Checks for:

  • all integration methods
  • kBET
  • LISI

LuckyMD
LuckyMD reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator
@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice overall, but the kBET test might need some work. Have you run pipeline test on this?

@mumichae
Copy link
Collaborator Author

The test is tailored to the Github actions workflow. In order for kBET to work properly, we'd need a proper R installation in the CI, which would be something for a separate workflow and PR.

@LuckyMD LuckyMD merged commit 0706362 into master Sep 17, 2021
@LuckyMD
Copy link
Collaborator
LuckyMD commented Sep 17, 2021

Thanks @mumichae !

@LuckyMD LuckyMD deleted the check_methods branch September 17, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckyMD LuckyMD LuckyMD approved these changes

@mbuttner mbuttner Awaiting requested review from mbuttner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mumichae @LuckyMD @mbuttner
0