Packaging #272
Merged
Packaging #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyMD
reviewed
Oct 4, 2021
* add per batch trajectory score * Update trajectory.py add missing comma * Update trajectory.py import pandas * don't recompute trajectories per batch * correct batch var handling * Update trajectory.py * Check batch key * add tests for trajectory score * update test values * update test values Co-authored-by: Strobl <daniel.strobl@mb084184.dyn.scidom.de> Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
LuckyMD
reviewed
Oct 18, 2021
LuckyMD
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Overall this looks very nice. Just two main points:
- Do we have a parallel PR in
scib-pipelineto ensure all of the scripts are using the correct function names? Or are we running our own module in a deprecated manner by default? - @danielStrobl can we assign batch in the trajectory score as you did? Why should this not already be in the second object?
LuckyMD
approved these changes
Oct 19, 2021
LuckyMD
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to compute trajectory score per batch and take the mean and not compute the score overall.
scIBtoscib! This will break old code, so all uses ofscIBhave to be renamed for this versionsetup.pytosetup.cfgrequirements.txtandrequirements_extra.txtmoved tosetup.cfg