10000 Update dependency versions by mumichae · Pull Request #294 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update dependency versions #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2022
Merged

Update dependency versions #294

merged 2 commits into from
Mar 21, 2022

Conversation

mumichae
Copy link
Collaborator
@mumichae mumichae commented Mar 7, 2022 •
edited
Loading

Remove version pins for numpy and h5py as requested in #283

@mumichae
Copy link
Collaborator Author
mumichae commented Mar 7, 2022

For some reason Github actions is returning NMI scores slightly larger than 1 during testing. I couldn't reproduce this error offline.

    def test_nmi_trivial(adata):
        score = scib.me.nmi(adata, 'celltype', 'celltype')
>       assert score == 1
E       assert 1.0000000000000002 == 1
E         +1.0000000000000002
E         -1

@mumichae mumichae requested a review from LuckyMD March 7, 2022 13:13
@Zethson
Copy link
Member
Zethson commented Mar 10, 2022 •
edited
Loading

Great, thank you! We'd also require a swift PyPI release after this PR is merged.

@mumichae mumichae merged commit c4ce6d1 into main Mar 21, 2022
@mumichae mumichae deleted the loosen_dep branch March 21, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckyMD LuckyMD Awaiting requested review from LuckyMD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mumichae @Zethson
0