8000 Add perfect isolabel ASW test by mumichae · Pull Request #362 · theislab/scib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add perfect isolabel ASW test #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add perfect isolabel ASW test #362

merged 1 commit into from
Jan 9, 2023

Conversation

mumichae
Copy link
Collaborator
@mumichae mumichae commented Jan 6, 2023

closes #359

@mumichae mumichae requested a review from LuckyMD January 6, 2023 18:13
@codecov
Copy link
codecov bot commented Jan 6, 2023

Codecov Report

Merging #362 (6f54d57) into main (896f689) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   53.13%   53.13%           
=======================================
  Files          22       22           
  Lines        1848     1848           
=======================================
  Hits          982      982           
  Misses        866      866           
Flag Coverage Δ
unittests 53.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@LuckyMD
Copy link
Collaborator
LuckyMD commented Jan 9, 2023

This works here?... very strange as it doesn't in open problems... but thanks!

@danielStrobl
Copy link
Member

Just looking over this as this doesn't seem to work in openproblems, this is testing the perfect baseline for iso label f1 and not iso label asw if I read the code correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add perfect score metric tests for isolated labels
3 participants
0