8000 Skip broken tests by n-rodriguez · Pull Request #235 · thoughtbot/appraisal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Skip broken tests #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

@@ -59,6 +62,8 @@
end

it "sets the heading and single_quotes" do
pending("test is broken: wrong number of arguments (given 0, expected 1)")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [84/80]

@@ -35,6 +36,8 @@
end

it "sets the heading" do
pending("test is broken: wrong number of arguments (given 0, expected 1)")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [84/80]

@@ -3,6 +3,7 @@

# Requiring this to make the test pass on Rubinius 2.2.5
# https://github.com/rubinius/rubinius/issues/2934
require 'rspec/matchers/composable'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@nickcharlton nickcharlton merged commit ddb3eb0 into thoughtbot:main Sep 23, 2024
1 check passed
@n-rodriguez n-rodriguez deleted the fix/skip_broken_tests branch September 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0