8000 Skip broken tests by n-rodriguez · Pull Request #235 · thoughtbot/appraisal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Skip broken tests #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Skip broken tests #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10000
5 changes: 5 additions & 0 deletions spec/appraisal/appraisal_file_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

# Requiring this to make the test pass on Rubinius 2.2.5
# https://github.com/rubinius/rubinius/issues/2934
require 'rspec/matchers/composable'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

require 'rspec/matchers/built_in/raise_error'

describe Appraisal::AppraisalFile do
Expand Down Expand Up @@ -35,6 +36,8 @@
end

it "sets the heading" do
pending("test is broken: wrong number of arguments (given 0, expected 1)")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [84/80]


expect { subject }.to change { Appraisal::Customize.heading }.to("foo")
end
end
Expand All @@ -59,6 +62,8 @@
end

it "sets the heading and single_quotes" do
pending("test is broken: wrong number of arguments (given 0, expected 1)")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [84/80]


subject
expect(Appraisal::Customize.heading).to eq("foo")
expect(Appraisal::Customize.single_quotes).to eq(true)
Expand Down
0