Alpine C Binding #105
Alpine C Binding #105
Conversation
Added Alpine instructions
|
|
README.md
Outdated
| @@ -24,6 +24,12 @@ Still here? To build the H3 C library, you'll need a C compiler (tested with `gc | |||
|
|
|||
| #### Install build-time dependencies | |||
|
|
|||
| * Alpine | |||
| ``` | |||
| # Installing the bare build buid requirements | |||
There was a problem hiding this comment.
Should this read the bare build requirements?
|
Thanks for your PR. Just a heads up I'm opening a PR to remove the unnecessary C++ dependency: #107 |
README.md
Outdated
| * Alpine | ||
| ``` | ||
| # Installing the bare build buid requirements | ||
| apk add cmake make gcc libtool musl-dev g++ |
There was a problem hiding this comment.
now that @isaacbrodsky merged his PR, you can drop g++
Fixed typo + removed g++ from requirements
| * Alpine | ||
| ``` | ||
| # Installing the bare build requirements | ||
| apk add cmake make gcc libtool musl-dev |
There was a problem hiding this comment.
I wonder if https://pkgs.alpinelinux.org/package/v3.3/main/x86/libc-dev is the package we should recommend? I wasn't able to find a good example of these instructions.
There was a problem hiding this comment.
Do you mean run more tests?
There was a problem hiding this comment.
I can try it later, unless you want to update the PR. Since these instructions work, I can merge them after CI finishes.
There was a problem hiding this comment.
can double-check tomorrow
There was a problem hiding this comment.
make test succeeded + tested with some examples from the README
There was a problem hiding this comment.
also works with libc-dev instead of musl-dev.
Alpine C Binding
See #103