8000 Alpine C Binding by Alien2150 · Pull Request #105 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Alpine C Binding #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Alpine C Binding #105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a72594d
Update README.md
Alien2150 Jul 30, 2018
614cd24
Update README.md
Alien2150 Jul 30, 2018
a6a4c76
Update README.md
Alien2150 Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ Still here? To build the H3 C library, you'll need a C compiler (tested with `gc

#### Install build-time dependencies

* Alpine
```
# Installing the bare build requirements
apk add cmake make gcc libtool musl-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if https://pkgs.alpinelinux.org/package/v3.3/main/x86/libc-dev is the package we should recommend? I wasn't able to find a good example of these instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean run more tests?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try it later, unless you want to update the PR. Since these instructions work, I can merge them after CI finishes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can double-check tomorrow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test succeeded + tested with some examples from the README

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also works with libc-dev instead of musl-dev.

```

* Debian/Ubuntu

```
Expand Down
0