added sse http support #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @enesakar, when will this be merged? I think sse is necessary |
|
Hey @monkeyDluffy6017 reviewing now! |
This was referenced May 22, 2025
cdd3526 to
9434477
Compare
9434477 to
c2f695d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds HTTP and SSE support for the MCP server, allowing for web-based communication alongside stdio transport.
- Introduces new endpoints for HTTP (/mcp, /sse, /messages, /ping) with proper CORS and error handling.
- Updates the README configuration to reflect the new URL-based commands instead of the previous CLI-based approach.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Adds HTTP and SSE endpoints with server instance creation and transport handling logic. |
| README.md | Updates configuration instructions to use URLs instead of CLI commands. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/index.ts:201
- Consider providing an explicit sessionIdGenerator function rather than undefined to ensure reliable session ID generation for the HTTP transport.
const transport = new StreamableHTTPServerTransport({ sessionIdGenerator: undefined })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.