8000 chore: use cli arguments instead of environment variables by ryanleecode · Pull Request #211 · upstash/context7 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: use cli arguments instead of environment variables #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: use cli arguments instead of environment variables #211

wants to merge 1 commit into from

Conversation

ryanleecode
Copy link
Contributor

@mdogan mdogan requested a review from enesgules May 21, 2025 08:50
@mdogan
Copy link
mdogan commented May 21, 2025

I think we should support both (env and cli args) not to break existing installations. Args can have priority over env (if exists). Otherwise we can fallback to env vars as it's now.

@ryanleecode
Copy link
Contributor Author

I think we should support both (env and cli args) not to break existing installations. Args can have priority over env (if exists). Otherwise we can fallback to env vars as it's now.

Can we agree to remove dotenv if that is the case? This mcp server should not have access to the file system

@mdogan
Copy link
mdogan commented May 21, 2025

I think we should support both (env and cli args) not to break existing installations. Args can have priority over env (if exists). Otherwise we can fallback to env vars as it's now.

Can we agree to remove dotenv if that is the case? This mcp server should not have access to the file system

I agree. @enesakar & @enesgules: do you have any objections?

@enesgules
Copy link
Collaborator

There might be new env variables with the new sse and http support pr: #208
Let’s revisit this once that pr is merged

@ryanleecode
Copy link
Contributor Author

There might be new env variables with the new sse and http support pr: #208
Let’s revisit this once that pr is merged

if we are adding new env variables we should prefix them with CONTEXT7_ or something equivalent. this makes it easy to whitelist via --allow-env=CONTEXT7_*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesgules enesgules Awaiting requested review from enesgules

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanleecode @mdogan @enesgules
0