-
Notifications
You must be signed in to change notification settings - Fork 147
fix: interface objects #1055
New i 8000 ssue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: interface objects #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt possible types and typename
…ilter on it fix: skip adding __typename into resolved fields, when it is added by planner during rewrite
…hen interface do not have all types from a union
… union member type instead of a union
… concrete implementing type instead of an interface as return type
…as added to 2 planners of the same datasource
…the upstream query
…selection set; prevent adding __typename field suggestion for the datasource which do not have a union defined
This was referenced Feb 11, 2025
devsergiy
pushed a commit
that referenced
this pull request
Feb 11, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.150](v2.0.0-rc.149...v2.0.0-rc.150) (2025-02-11) ### Bug Fixes * interface objects ([#1055](#1055)) ([858d929](858d929)) * re-walking operation on stopped walker after rewriting abstract selection set; prevent adding __typename field suggestion for the datasource which do not have a union defined ([cf50a60](cf50a60)) * use of arguments on interface object when jumping from type to interface object ([850bd6c](850bd6c)) * use of arguments on jump to interface object from concrete type ([#1061](#1061)) ([9f7180e](9f7180e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
devsergiy
pushed a commit
that referenced
this pull request
Jun 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](execution/v1.2.0...execution/v1.3.0) (2025-06-05) ### Features * add apollo router compat flag for invalid variable rendering ([#1067](#1067)) ([e87961f](e87961f)) * add deprecated arguments support to introspection ([#1142](#1142)) ([1ac2908](1ac2908)) * apollo-router-like non-ok http status errors ([#1072](#1072)) ([e685c29](e685c29)) * differentiate between complete and close event types ([#1158](#1158)) ([79f3f41](79f3f41)) * **engine:** mutex free subscription handling ([#1076](#1076)) ([21be4ab](21be4ab)) * implement gRPC datasource ([#1146](#1146)) ([146a552](146a552)) * update engine version for execution pkg ([#1171](#1171)) ([9769beb](9769beb)) ### Bug Fixes * fix printing object value with optional fields ([#1065](#1065)) ([5730d72](5730d72)) * handle scalar values for lists ([#1155](#1155)) ([94031e5](94031e5)) * interface objects ([#1055](#1055)) ([858d929](858d929)) * print indent once per level by default ([#1147](#1147)) ([0f022e5](0f022e5)), closes [#405](#405) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ENG-6082
fixes ENG-6084
fixes ENG-6086
fixes ENG-6094
fixes ENG-6095
fixes ENG-6096
fixes ENG-6097