fix: handle scalar values for lists #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsergiy
approved these changes
May 22, 2025
575c65c to
d62f2a1
Compare
This was referenced May 23, 2025
Noroth
pushed a commit
that referenced
this pull request
May 27, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.182](v2.0.0-rc.181...v2.0.0-rc.182) (2025-05-27) ### Bug Fixes * handle scalar values for lists ([#1155](#1155)) ([94031e5](94031e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
devsergiy
pushed a commit
that referenced
this pull request
Jun 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](execution/v1.2.0...execution/v1.3.0) (2025-06-05) ### Features * add apollo router compat flag for invalid variable rendering ([#1067](#1067)) ([e87961f](e87961f)) * add deprecated arguments support to introspection ([#1142](#1142)) ([1ac2908](1ac2908)) * apollo-router-like non-ok http status errors ([#1072](#1072)) ([e685c29](e685c29)) * differentiate between complete and close event types ([#1158](#1158)) ([79f3f41](79f3f41)) * **engine:** mutex free subscription handling ([#1076](#1076)) ([21be4ab](21be4ab)) * implement gRPC datasource ([#1146](#1146)) ([146a552](146a552)) * update engine version for execution pkg ([#1171](#1171)) ([9769beb](9769beb)) ### Bug Fixes * fix printing object value with optional fields ([#1065](#1065)) ([5730d72](5730d72)) * handle scalar values for lists ([#1155](#1155)) 79E7 ([94031e5](94031e5)) * interface objects ([#1055](#1055)) ([858d929](858d929)) * print indent once per level by default ([#1147](#1147)) ([0f022e5](0f022e5)), closes [#405](#405) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to enhance gRPC-based GraphQL data source functionality, improve error handling, and add new features for handling recursive types and complex data structures. The changes include both core functionality updates and test enhancements.
Core Functionality Enhancements:
NewFactoryGRPCClientProviderto allow dynamic provisioning of gRPC clients, enabling client recreation on connection errors. (v2/pkg/engine/datasource/graphql_datasource/graphql_datasource.go) [1] [2]Disabledflag in theGRPCConfigurationandDataSourceConfigto allow conditional enabling or disabling of gRPC data sources. (v2/pkg/engine/datasource/grpc_datasource/configuration.go,v2/pkg/engine/datasource/grpc_datasource/grpc_datasource.go) [1] [2] [3] [4] [5]v2/pkg/engine/datasource/grpc_datasource/grpc_datasource.go)Recursive Type and Data Handling:
execution/engine/execution_engine_grpc_test.go)marshalResponseJSONandsetArrayItemmethods to handle null values in protobuf messages and lists. (v2/pkg/engine/datasource/grpc_datasource/grpc_datasource.go) [1] [2] [3]Test and Mapping Enhancements:
v2/pkg/engine/datasource/grpc_datasource_test.go) [1] [2] [3] [4]orderLinesandmodifiers. (v2/pkg/grpctest/mapping/mapping.go,v2/pkg/grpctest/mockservice.go,v2/pkg/grpctest/product.proto) [1] [2] [3]