Eliminate dot imports #2002
Eliminate dot imports #2002
Conversation
|
Why not a few strategically placed instead? |
|
Why pollute the global namespace with a variable and introduce an additional layer of indirection just to save a few keystrokes? |
|
those keystrokes you are saving are adding noise for the reader, i.e. it's not about writing less but reading less. |
|
They don't add noise, rather explicitness. The goal is to minimize ambiguity, not quantity of characters, and |
|
|
|
overall, may I ask what problem we are trying to solve here? |
https://github.com/golang/go/wiki/CodeReviewComments#import-dot |
|
And has anybody actually run into this problem when reading the weave code? |
|
I have. |
|
So you read the weave code, came across a statement like and wondered "Where does |
|
For those bits of code that are really libraries, it might be better to pass in a logger reference on startup, then the caller has control. |
64b48aa to
28ff34e
Compare
|
I wanted to force the issue of refactoring |
d77d633 to
0d6d148
Compare
|
@bboreham is there a reason we can't just merge this now? It's a strict refactoring... |
|
Because it makes the code strictly more ugly. |
I was hoping that #2002 (comment) might be an acceptable compromise. |
My point being that it makes it more ugly on purpose. Further refactorings become easier once everything is fully qualified. |
0d6d148 to
e0305b4
Compare
|
I have eliminated the bulk of dot imports. The remainder will be removed with #2074. -> closing. |
They're bad, m'kay?
cc @peterbourgon