This repository was archived by the owner on Jun 20, 2024. It is now read-only.
clean up plugin logging #2074
Merged
clean up plugin logging #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee93ba0 to
1a2d132
Compare
Closed
8000
|
Needs rebase |
4ab778c to
35eb05c
Compare
35eb05c to
448b1b6
Compare
CNI is invoked from the command line; so there is no point in getting clever about logging.
It is a library function, so logging of any errors should be left to the caller. We also get rid of a logged warning which contained the complete data structure returned by netlink.LinkByName. So this function now does no logging at all. Which is how it should be.
Consistency, consistency, consistency: - prefix all log messages with "[net]" - important since the same process acts as both a network and ipam driver - include the API function name in all log messages - log request and response details at debug level - log request summary at info level - log ContainerStarted as a pseudo API function, but only at debug level (since it can be quite high volume) And eliminate some dot imports.
prefix all log entries with "[ipam]" Also eliminate a dot import.
- log requests at info level instead of debug level - log errors at error level instead of debug level
448b1b6 to
4482d30
Compare
|
@awh this is ready (again) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistency, consistency, consistency
and elimination of dot imports.