Refactored Experience Level Calculation for Personnel #6440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced local variables for `CampaignOptions` settings to improve readability and reduce repeated calls. - Added support for alternative quality averaging and administration skill checks for mechanics, technicians, vessel crew, aerospace techs, battle armor techs, and doctors. - Simplified conditional checks for skill-based experience calculations by leveraging the new variables.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6440 +/- ##
============================================
- Coverage 11.28% 11.27% -0.02%
+ Complexity 6289 6285 -4
============================================
Files 1073 1073
Lines 136745 136818 +73
Branches 21151 21176 +25
============================================
- Hits 15430 15422 -8
- Misses 119766 119850 +84
+ Partials 1549 1546 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CampaignOptionssettings to improve readability and reduce repeated calls.Requirements
Requires #6436 && #6438
Dev Notes
This just updates our skill level (Green, Regular, etc) calculations to factor in Administration if the 'Doctors Have' and/or 'Techs Have' options are enabled.