8000 Adjusted Missing Team Fallback Logging by IllianiBird · Pull Request #6625 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjusted Missing Team Fallback Logging #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Adjusted Missing Team Fallback Logging #6625

merged 1 commit into from
Apr 11, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Adjusted logic to apply fallback team value only for scenarios with a current status. Stops it spamming up mekhq.log

@IllianiBird
Adjusted Missing Team Fallback Logging
5a7021d 
- Adjusted logic to apply fallback team value only for scenarios with a current status. Stops it spamming up `mekhq.log`
@IllianiBird IllianiBird self-assigned this Apr 11, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.43%. Comparing base (2fef8ef) to head (5a7021d).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/mission/Scenario.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6625   +/-   ##
=========================================
  Coverage     11.43%   11.43%           
- Complexity     6451     6456    +5     
=========================================
  Files          1086     1086           
  Lines        139459   139460    +1     
  Branches      21571    21572    +1     
=========================================
+ Hits          15948    15951    +3     
+ Misses       121914   121911    -3     
- Partials       1597     1598    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit a7baaf7 into MegaMek:master Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhancock rjhancock rjhancock approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @rjhancock
0