Fix #6771: Loosened Government Force Command Rights Re-Roll Restrictions #6774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed restrictions for government forces when determining command clause reroll eligibility.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6774 +/- ##
============================================
+ Coverage 11.40% 11.43% +0.03%
+ Complexity 6482 6479 -3
============================================
Files 1095 1094 -1
Lines 141048 140663 -385
Branches 21884 21805 -79
============================================
+ Hits 16082 16091 +9
+ Misses 123308 122914 -394
Partials 1658 1658 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR loosens command clause reroll restrictions by allowing government forces to be eligible, removing prior checks that restricted rerolls to mercenaries and pirates.
- Removed faction-based restrictions for command rerolls
- Updated the logic in ContractSummaryPanel.java to reflect this behavioral change
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/gui/view/ContractSummaryPanel.java:560
- The removal of the faction-specific checks (isMercenary and isPirate) now allows government forces to reroll commands. Please update the in 8000 line comment to clarify that this change in business logic is intentional and align it with the updated requirements.
private boolean hasCommandRerolls() {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6771