Fix: #7017 Fixed Mass Repair Dialog Throwing Error in Warehouse #7018
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7018 +/- ##
=========================================
Coverage 12.03% 12.03%
- Complexity 6882 6886 +4
=========================================
Files 1102 1102
Lines 142171 142198 +27
Branches 21976 21985 +9
=========================================
+ Hits 17115 17119 +4
- Misses 123221 123245 +24
+ Partials 1835 1834 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses error #7017 by explicitly initializing the parts data in the MRMS Dialog to prevent errors when the Mass Repair Dialog is displayed.
- Explicitly initializes partsTableModel's data with an empty ArrayList
- Ensures the GUI component (partsTable) is constructed with an initialized model
| @@ -395,6 +395,7 @@ private JPanel createPartsPanel() { | |||
| "PartsPanel.title")), BorderFactory.createEmptyBorder(5, 5, 5, 5))); | |||
|
|
|||
| partsTableModel = new PartsTableModel(); | |||
| partsTableModel.setData(new ArrayList<>()); | |||
There was a problem hiding this comment.
While this explicit initialization resolves the error, consider moving the data initialization to the PartsTableModel constructor to encapsulate the default state and reduce dependency on external initialization in the UI logic.
Copilot uses AI. Check for mistakes.
Fix #7017
This data should initialize as part of the object initialization but, for some reason, isn't. So now we explicitly initialize it within MRMS removing the error.