8000 Fix: #7017 Fixed Mass Repair Dialog Throwing Error in Warehouse by IllianiBird · Pull Request #7018 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #7017 Fixed Mass Repair Dialog Throwing Error in Warehouse #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Fix: #7017 Fixed Mass Repair Dialog Throwing Error in Warehouse #7018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527d71b
Fix: Fixed Mass Repair Dialog Throwing Error in Warehouse
IllianiBird May 15, 2025
a099e53
Merge branch 'master' into massRepairWarehouseError
HammerGS May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
1 change: 1 addition & 0 deletions MekHQ/src/mekhq/gui/dialog/MRMSDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ private JPanel createPartsPanel() {
"PartsPanel.title")), BorderFactory.createEmptyBorder(5, 5, 5, 5)));

partsTableModel = new PartsTableModel();
partsTableModel.setData(new ArrayList<>());
Copy link
Preview
Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this explicit initialization resolves the error, consider moving the data initialization to the PartsTableModel constructor to encapsulate the default state and reduce dependency on external initialization in the UI logic.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant

partsTable = new JTable(partsTableModel);
partsTable.setAutoResizeMode(JTable.AUTO_RESIZE_ALL_COLUMNS);
partsTable.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
Expand Down
Loading
0