8000 fix(linter): correctly inherit categories when plugins are enabled by camc314 · Pull Request #11353 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(linter): correctly inherit categories when plugins are enabled #11353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

fix(linter): correctly inherit categories when plugins are enabled #11353

merged 1 commit into from
Jun 5, 2025

Conversation

camc314
Copy link
Contributor
@camc314 camc314 commented May 28, 2025 •
edited
Loading

fixes #10394
fixes #9649

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels May 28, 2025
@camc314 Graphite App
Copy link
Contributor Author
camc314 commented May 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11353 will degrade performances by 14.89%

Comparing c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled (10d35e1) with main (90b8b33)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ mangler[cal.com.tsx] 3 ms 3.5 ms -14.89%

@camc314 camc314 force-pushed the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch from c6dcd96 to c35d041 Compare May 29, 2025 10:39
@github-actions github-actions bot added the A-cli Area - CLI label May 29, 2025
@camc314 camc314 marked this pull request as ready for review May 29, 2025 10:39
@camc314 camc314 force-pushed the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch from c35d041 to 9b48a17 Compare May 29, 2025 10:40
@camc314 camc314 requested a review from Sysix May 29, 2025 10:41
@camc314 camc314 marked this pull request as draft May 29, 2025 11:55
@camc314 camc314 force-pushed the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch 15 times, most recently from b120c90 to 54840e1 Compare June 5, 2025 11:52
@camc314 camc314 marked this pull request as ready for review June 5, 2025 11:52
@camc314 camc314 force-pushed the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch from 54840e1 to a2941f7 Compare June 5, 2025 11:59
@camc314 camc314 force-pushed the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch from a2941f7 to 10d35e1 Compare June 5, 2025 12:00
camc314
camc314 commented Jun 5, 2025
View reviewed changes
@camc314
Copy link
Contributor Author
camc314 commented Jun 5, 2025

@Sysix this should be ready, mind taking a quick look over it please 🙏

Sysix
Sysix reviewed Jun 5, 2025
View reviewed changes
Copy link
Member
@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are now storing categories which are allowed. I guess this is not really needed?
The Store + Builder is an area which I need to understand it better

@camc314
Copy link
Contributor Author
camc314 commented Jun 5, 2025

Looks like we are now storing categories which are allowed. I guess this is not really needed?

yes unfortunately we do need to store it. e.g.

{
    "categories": { 
        "style": "true",
        "correctness": "true"
    },
    "overrides": [
        {
            "plugins": ["jest"]
            // we need to store root categories so we can enable jest/style + jest/correctness
        }
    ]
}

@camc314 camc314 merged commit 0946dac into main Jun 5, 2025
24 checks passed
@camc314 camc314 deleted the c/05-28-fix_linter_correctly_inherit_categories_when_plugins_are_enabled branch June 5, 2025 19:41
@Sysix
Copy link
Member
Sysix commented Jun 5, 2025

@camc314 I was talking about "style/correctness": "off"

This was referenced Jun 6, 2025
Closed
Merged
camc314 added a commit that referenced this pull request Jun 6, 2025
@oxc-bot @camc314
release(oxlint): v0.18.0 (#11530)
85b80dc 
## [0.18.0] - 2025-06-06

- bd9dd88 linter: [**BREAKING**] Add more info to json reporter (#11524)
(camc314)

### Features

- 825d40c linter: Fix casing in
unicorn/no-useless-promise-resolve-reject (#11528) (camc314)
- 2faee3d linter: Fix grammer in react/exhaustive-deps (#11527)
(camc314)

### Bug Fixes

- 1a71d7c linter: Misplaced backtick in unicorn/no-array-for-each
diagnostic (#11529) (camc314)
- 7430b14 linter: Grammer in jest/valid-expect diagnostic (#11522)
(camc314)
- b92ac41 linter: Grammer in eslint/no-redeclare diagnostic (#11521)
(camc314)
- 17883e3 linter: Improve eslint/no-unsafe-negation diagnostic (#11520)
(camc314)
- 8c89937 linter: Improve eslint/no-shadow-restricted-names diagnostic
(#11519) (camc314)
- 3f0d889 linter: Add missing article to
oxc/bad-array-method-on-arguments diagnostic (#11518) (camc314)
- cf0c24c linter: Improve message in react/prefer-es6-class diagnostic
(#11516) (camc314)
- 91855df linter: Fix message in react/rules-of-hooks diagnostic
(#11515) (camc314)
- b272194 linter: Misplaced backtick in jest/no-conditional-expect
diagnostic (#11514) (camc314)
- 3403303 linter: Misplaced backtick in unicorn/prefer-dom-node-dataset
diagnostic (#11513) (camc314)
- d5ca872 linter: Misplaced backtick in eslint/radix diagnostic (#11512)
(camc314)
- 2dcf8be linter: Improve diagnostic message when function name is
referenced (#11509) (camc314)
- 0de0c9c linter: Improve diagnostic message for
no-unsafe-declaration-merging (#11508) (camc314)
- 0946dac linter: Correctly inherit categories when plugins are enabled
(#11353) (Cameron)
- 510c1c6 linter: Add missing `allowArrowFunctions` option for
eslint/func-style (#11455) (yefan)
- c77787c linter: Improve `eslint/no-loss-of-precision` (#11437)
(magic-akari)
- 11d4523 linter: False positive in react/exhaustive-deps (#11438)
(camc314)
- 616b613 linter/switch-case-braces: Align the logic with `unicorn`
(#11405) (shulaoda)

### Refactor

- db0b099 language_server: Convert only once uri to path when creating
`ServerLinter` (#11503) (Sysix)
- ccceb52 language_server: Simplify `workspace/didChangeConfiguration`
call (#11462) (Sysix)
- 0fdc51e linter: Simplify `OxlintRules::override_rules` (#11510)
(camc314)

### Testing

- 2ba2893 editor: Fix test for auto `fixAll` on save (#11448) (Sysix)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sysix Sysix Sysix approved these changes

Assignees
No one assigned
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linter: plugins inside overrides don't get applied linter: Overrides property is not working with "Vitest" plugin
2 participants
@camc314 @Sysix
0