8000 fix(linter): improve eslint/no-shadow-restricted-names diagnostic by camc314 · Pull Request #11519 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(linter): improve eslint/no-shadow-restricted 8000 -names diagnostic #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

camc314
Copy link
Contributor
@camc314 camc314 commented Jun 6, 2025

No description provided.

Copy link
Contributor Author
camc314 commented Jun 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Jun 6, 2025
@camc314 camc314 marked this pull request as ready for review June 6, 2025 10:57
@camc314 camc314 changed the base branch from c/06-06-fix_linter_add_missing_article_to_oxc_bad-array-method-on-arguments_diagnostic to graphite-base/11519 June 6, 2025 10:58
@camc314 camc314 force-pushed the c/06-06-fix_linter_improve_eslint_no-shadow-restricted-names_diagnostic branch from 0747b48 to 7951caa Compare June 6, 2025 11:00
@camc314 camc314 force-pushed the graphite-base/11519 branch from 9482b83 to b46673e Compare June 6, 2025 11:00
@camc314 camc314 changed the base branch from graphite-base/11519 to c/06-06-fix_linter_add_missing_article_to_oxc_bad-array-method-on-arguments_diagnostic June 6, 2025 11:00
@graphite-app graphite-app bot changed the base branch from c/06-06-fix_linter_add_missing_article_to_oxc_bad-array-method-on-arguments_diagnostic to graphite-base/11519 June 6, 2025 11:00
Copy link
codspeed-hq bot commented Jun 6, 2025

CodSpeed Instrumentation Performance Report

Merging #11519 will degrade performances by 12.86%

Comparing c/06-06-fix_linter_improve_eslint_no-shadow-restricted-names_diagnostic (8c89937) with main (3f0d889)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.86%

@camc314 camc314 force-pushed the graphite-base/11519 branch from b46673e to 3f0d889 Compare June 6, 2025 11:03
@camc314 camc314 force-pushed the c/06-06-fix_linter_improve_eslint_no-shadow-restricted-names_diagnostic branch from 7951caa to aaa0790 Compare June 6, 2025 11:03
@camc314 camc314 changed the base branch from graphite-base/11519 to c/06-06-fix_linter_add_missing_article_to_oxc_bad-array-method-on-arguments_diagnostic June 6, 2025 11:03
@graphite-app graphite-app bot changed the base branch from c/06-06-fix_linter_add_missing_article_to_oxc_bad-array-method-on-arguments_diagnostic to main June 6, 2025 11:04
Copy link
Contributor
graphite-app bot commented Jun 6, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-06-fix_linter_improve_eslint_no-shadow-restricted-names_diagnostic branch from aaa0790 to 8c89937 Compare June 6, 2025 11:08
@graphite-app graphite-app bot merged commit 8c89937 into main Jun 6, 2025
23 checks passed
@graphite-app graphite-app bot deleted the c/06-06-fix_linter_improve_eslint_no-shadow-restricted-names_diagnostic branch June 6, 2025 11:11
This was referenced Jun 6, 2025
camc314 added a commit that referenced this pull request Jun 6, 2025
## [0.18.0] - 2025-06-06

- bd9dd88 linter: [**BREAKING**] Add more info to json reporter (#11524)
(camc314)

### Features

- 825d40c linter: Fix casing in
unicorn/no-useless-promise-resolve-reject (#11528) (camc314)
- 2faee3d linter: Fix grammer in react/exhaustive-deps (#11527)
(camc314)

### Bug Fixes

- 1a71d7c linter: Misplaced backtick in unicorn/no-array-for-each
diagnostic (#11529) (camc314)
- 7430b14 linter: Grammer in jest/valid-expect diagnostic (#11522)
(camc314)
- b92ac41 linter: Grammer in eslint/no-redeclare diagnostic (#11521)
(camc314)
- 17883e3 linter: Improve eslint/no-unsafe-negation diagnostic (#11520)
(camc314)
- 8c89937 linter: Improve eslint/no-shadow-restricted-names diagnostic
(#11519) (camc314)
- 3f0d889 linter: Add missing article to
oxc/bad-array-method-on-arguments diagnostic (#11518) (camc314)
- cf0c24c linter: Improve message in react/prefer-es6-class diagnostic
(#11516) (camc314)
- 91855df linter: Fix message in react/rules-of-hooks diagnostic
(#11515) (camc314)
- b272194 linter: Misplaced backtick in jest/no-conditional-expect
diagnostic (#11514) (camc314)
- 3403303 linter: Misplaced backtick in unicorn/prefer-dom-node-dataset
diagnostic (#11513) (camc314)
- d5ca872 linter: Misplaced backtick in eslint/radix diagnostic (#11512)
(camc314)
- 2dcf8be linter: Improve diagnostic message when function name is
referenced (#11509) (camc314)
- 0de0c9c linter: Improve diagnostic message for
no-unsafe-declaration-merging (#11508) (camc314)
- 0946dac linter: Correctly inherit categories when plugins are enabled
(#11353) (Cameron)
- 510c1c6 linter: Add missing `allowArrowFunctions` option for
eslint/func-style (#11455) (yefan)
- c77787c linter: Improve `eslint/no-loss-of-precision` (#11437)
(magic-akari)
- 11d4523 linter: False positive in react/exhaustive-deps (#11438)
(camc314)
- 616b613 linter/switch-case-braces: Align the logic with `unicorn`
(#11405) (shulaoda)

### Refactor

- db0b099 language_server: Convert only once uri to path when creating
`ServerLinter` (#11503) (Sysix)
- ccceb52 language_server: Simplify `workspace/didChangeConfiguration`
call (#11462) (Sysix)
- 0fdc51e linter: Simplify `OxlintRules::override_rules` (#11510)
(camc314)

### Testing

- 2ba2893 editor: Fix test for auto `fixAll` on save (#11448) (Sysix)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0