fix(linter/switch-case-braces): align the logic with unicorn
#11405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11405 will not alter performanceComparing Summary
|
25454b0 to
c71f8e6
Compare
shulaoda
commented
May 30, 2025
shulaoda
commented
May 30, 2025
unicorn
Merge activity
|
In the case of `switch(foo){ case 1: {}; break; }`, only a "Missing braces in case clause" diagnostic should be reported.
However, the current behavior incorrectly reports below:
```bash
⚠ eslint-plugin-unicorn(switch-case-braces): Unexpected braces in empty case clause.
╭─[switch_case_braces.tsx:1:22]
1 │ switch(foo){ case 1: {}; break; }
· ──
╰────
help: Remove braces in empty case clause.
⚠ eslint-plugin-unicorn(switch-case-braces): Missing braces in case clause.
╭─[switch_case_braces.tsx:1:22]
1 │ switch(foo){ case 1: {}; break; }
· ──────────
╰────
help: Add Braces for case clause.
```
c71f8e6 to
616b613
Compare
This was referenced Jun 6, 2025
camc314
added a commit
that referenced
this pull request
Jun 6, 2025
## [0.18.0] - 2025-06-06 - bd9dd88 linter: [**BREAKING**] Add more info to json reporter (#11524) (camc314) ### Features - 825d40c linter: Fix casing in unicorn/no-useless-promise-resolve-reject (#11528) (camc314) - 2faee3d linter: Fix grammer in react/exhaustive-deps (#11527) (camc314) ### Bug Fixes - 1a71d7c linter: Misplaced backtick in unicorn/no-array-for-each diagnostic (#11529) (camc314) - 7430b14 linter: Grammer in jest/valid-expect diagnostic (#11522) (camc314) - b92ac41 linter: Grammer in eslint/no-redeclare diagnostic (#11521) (camc314) - 17883e3 linter: Improve eslint/no-unsafe-negation diagnostic (#11520) (camc314) - 8c89937 linter: Improve eslint/no-shadow-restricted-names diagnostic (#11519) (camc314) - 3f0d889 linter: Add missing article to oxc/bad-array-method-on-arguments diagnostic (#11518) (camc314) - cf0c24c linter: Improve message in react/prefer-es6-class diagnostic (#11516) (camc314) - 91855df linter: Fix message in react/rules-of-hooks diagnostic (#11515) (camc314) - b272194 linter: Misplaced backtick in jest/no-conditional-expect diagnostic (#11514) (camc314) - 3403303 linter: Misplaced backtick in unicorn/prefer-dom-node-dataset diagnostic (#11513) (camc314) - d5ca872 linter: Misplaced backtick in eslint/radix diagnostic (#11512) (camc314) - 2dcf8be linter: Improve diagnostic message when function name is referenced (#11509) (camc314) - 0de0c9c linter: Improve diagnostic message for no-unsafe-declaration-merging (#11508) (camc314) - 0946dac linter: Correctly inherit categories when plugins are enabled (#11353) (Cameron) - 510c1c6 linter: Add missing `allowArrowFunctions` option for eslint/func-style (#11455) (yefan) - c77787c linter: Improve `eslint/no-loss-of-precision` (#11437) (magic-akari) - 11d4523 linter: False positive in react/exhaustive-deps (#11438) (camc314) - 616b613 linter/switch-case-braces: Align the logic with `unicorn` (#11405) (shulaoda) ### Refactor - db0b099 language_server: Convert only once uri to path when creating `ServerLinter` (#11503) (Sysix) - ccceb52 language_server: Simplify `workspace/didChangeConfiguration` call (#11462) (Sysix) - 0fdc51e linter: Simplify `OxlintRules::override_rules` (#11510) (camc314) ### Testing - 2ba2893 editor: Fix test for auto `fixAll` on save (#11448) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of
switch(foo){ case 1: {}; break; }, only a "Missing braces in case clause" diagnostic should be reported.However, the current behavior incorrectly reports below: