8000 ENG-1168 - Remove Coco Jr promotion in classroom version by adamkecskes · Pull Request #7708 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENG-1168 - Remove Coco Jr promotion in classroom version #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

ENG-1168 - Remove Coco Jr promotion in classroom version #7708

merged 1 commit into from
Sep 17, 2024

Conversation

adamkecskes
Copy link
Collaborator
@adamkecskes adamkecskes commented Sep 17, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced a conditional button for "CodeCombat Junior" in the campaign view, enhancing user interaction based on specific view conditions.
    • Improved user role handling for junior-level users, refining eligibility checks for functionalities.

  • Bug Fixes

    • Adjusted control flow to ensure the button only displays when appropriate conditions are met.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 17, 2024 •
edited
Loading

Walkthrough

The changes introduced in this pull request enhance the conditional rendering logic in the campaign-view.pug template and the CampaignView class. The modifications ensure that a button related to "CodeCombat Junior" is displayed only when specific conditions are met, refining user eligibility checks for junior-level interactions. This aligns with the objective of removing the promotion for the classroom version as specified in the linked issues.

Changes

Files Change Summary
app/templates/play/campaign-view.pug Added a conditional check to display the "CodeCombat Junior" button based on view.shouldShow('junior-level').
app/views/play/CampaignView.js Introduced a new condition in the CampaignView class to handle user interactions for 'junior-level', allowing early returns for home users in specific cases.

Assessment against linked issues

Objective Addressed Explanation
Remove Coco Jr promotion in classroom version (ENG-1168) ✅

Possibly related PRs

Poem

In the land of code where rabbits play,
A button now hides, come what may.
For junior levels, it peeks just right,
A clever check brings it to light.
Hooray for changes, let’s hop and cheer,
In our coding burrow, joy is near! 🐇✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2f99bed and bb618d1.

Files selected for processing (2)
  • app/templates/play/campaign-view.pug (1 hunks)
  • app/views/play/CampaignView.js (1 hunks)
Additional comments not posted (2)
app/templates/play/campaign-view.pug (1)

355-356: Conditional rendering of the CodeCombat Junior button looks good!

The added conditional check view.shouldShow('junior-level') ensures that the button is only displayed when appropriate, likely when not in the classroom version. This aligns well with the PR objective of removing the Coco Jr promotion from the classroom version.

app/views/play/CampaignView.js (1)

2043-2045: The changes look good!

The updated shouldShow logic for the "junior-level" case ensures that the Coco Jr promotion is only shown to home users and not in the classroom version. This aligns with the PR objective.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mrfinch mrfinch merged commit 4218e89 into master Sep 17, 2024
2 checks passed
@mrfinch mrfinch deleted the adamk/remove-coco-jr-promotion-in-classroom-version branch September 17, 2024 18:21
This was referenced Sep 17, 2024
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 14, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 26, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrfinch mrfinch mrfinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkecskes @mrfinch
0