8000 i18n for readonly scenario view by adamkecskes · Pull Request #7863 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

i18n for readonly scenario view #7863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2024
Merged

i18n for readonly scenario view #7863

merged 2 commits into from
Dec 11, 2024

Conversation

adamkecskes
Copy link
Collaborator
@adamkecskes adamkecskes commented Nov 29, 2024 •
edited by coderabbitai bot
Loading

client for https://github.com/codecombat/ai/pull/306

Summary by CodeRabbit

  • New Features

    • Introduced new AI-related sections, including "AI HackStack," enhancing project creation tools.
    • Added resources for parents and professional development, improving engagement and support.
    • Updated content to better align with educational standards and clarify course offerings.
    • New sections added for Roblox integration and community engagement opportunities.

  • Improvements

    • Enhanced user interface language for clarity and user-friendliness.
    • Organized localization file for easier access to specific content areas.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 29, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces extensive modifications to the English localization file (app/locale/en.js). Key updates include the addition of new sections related to AI features, parent engagement, and professional development, as well as enhancements to existing content for clarity and user engagement. The overall structure of the localization file has been refined to improve access to educational resources and user interface elements, ensuring consistency and support for the platform's educational goals.

Changes

File Change Summary
app/locale/en.js - Added new sections: ai_hackstack, parents_v2, roblox, pd_page, hackstack_page, standards_page, codequest_page.
- Modified existing sections for clarity and engagement, focusing on educational standards and user navigation.

Possibly related PRs

Suggested reviewers

  • mrfinch

🐰 In the meadow, changes bloom,
New sections sprout, dispelling gloom.
AI tools and parents unite,
With clearer paths, we take flight.
Educators cheer, students play,
Localization brightens the day! 🌼

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dd3af3f and 178b14a.

📒 Files selected for processing (1)
  • app/locale/en.js (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
app/locale/en.js (2)

Line range hint 4-4: Consider adding a comment to explain the purpose of this object.

While the object name nativeDescription implies it's a description in the native language, adding a brief comment to clarify its purpose would improve code readability.

Line range hint 5-5: Consider adding a comment to explain the purpose of this object.

Similar to nativeDescription, adding a comment to explain what englishDescription represents would help make the code more self-documenting.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 52e9e1f and dd3af3f.

📒 Files selected for processing (1)
  • app/locale/en.js (1 hunks)
🔇 Additional comments (70)
app/locale/en.js (70)

Line range hint 1-2: Looks good!

The module exports an object containing the English locale translations.

Line range hint 6-6: Looks good!

The translation object will contain the actual translations for various keys.

Line range hint 8-37: Looks good!

The ozaria_home object contains translations for the Ozaria home page.

Line range hint 39-81: Looks good!

The new_home object contains translations for the new home page.

Line range hint 83-107: Looks good!

The nav object contains translations for the navigation menu items.

Line range hint 109-121: Looks good!

The modal object contains translations for modal-related text.

Line range hint 123-125: Looks good!

The not_found object contains translations for the "not found" page.

Line range hint 127-134: Looks good!

The diplomat_suggestion object contains translations for the diplomat suggestion feature.

Line range hint 136-167: Looks good!

The new_home_faq object contains translations for the FAQ section on the new home page.

Line range hint 169-339: Looks good!

The play object contains translations for the gameplay-related text.

Line range hint 341-391: Looks good!

The apis object contains translations for the API documentation.

Line range hint 393-403: Looks good!

The amazon_hoc object contains translations for the Amazon Hour of Code feature.

Line range hint 405-409: Looks good!

The live_class object contains translations for the live class feature.

Line range hint 411-420: Looks good!

The code_quest object contains translations for the Code Quest feature.

Line range hint 422-460: Looks good!

The play_game_dev_level object contains translations for the game development levels.

Line range hint 462-487: Looks good!

The game_menu object contains translations for the game menu.

Line range hint 489-518: Looks good!

The leaderboard object contains translations for the leaderboard feature.

Line range hint 520-535: Looks good!

The inventory object contains translations for the inventory system.

Line range hint 537-553: Looks good!

The buy_gems object contains translations for the gem purchase feature.

Line range hint 555-558: Looks good!

The subscribe_for_gems object contains translations for the gem subscription feature.

Line range hint 560-563: Looks good!

The earn_gems object contains translations for the gem earning feature.

Line range hint 565-636: Looks good!

The subscribe object contains translations for the subscription feature.

Line range hint 638-643: Looks good!

The announcement object contains translations for announcements.

Line range hint 645-662: Looks good!

The ladder_prizes object contains translations for ladder prizes. However, the comment suggests this section is outdated and doesn't need new translations.

Line range hint 664-677: Looks good!

The calendar object contains translations for the calendar component.

Line range hint 679-685: Looks good!

The code_play_create_account_modal object contains translations for the account creation modal in the code play feature.

Line range hint 687-694: Looks good!

The server_error object contains translations for server error messages.

Line range hint 696-1005: Looks good!

The esper object contains translations for error messages and hints.

Line range hint 1007-1034: Looks good!

The apcsp object contains translations for the AP Computer Science Principles course.

Line range hint 1036-1112: Looks good!

The apcsp_marketing object contains translations for the marketing content of the AP Computer Science Principles course.

Line range hint 1114-1136: Looks good!

The apcsp_curriculum object contains translations for the curriculum of the AP Computer Science Principles course.

Line range hint 1138-1157: Looks good!

The hoc_2019 object contains translations for the Hour of Code 2019 event.

Line range hint 1159-1165: Looks good!

The hoc_2018_interstitial object contains translations for the interstitial content of the Hour of Code 2018 event.

Line range hint 1167-1179: Looks good!

The hoc_2018_completion object contains translations for the completion page of the Hour of Code 2018 event.

Line range hint 1181-1211: Looks good!

The share_progress_modal object contains translations for the share progress modal.

Line range hint 1213-1224: Looks good!

The login object contains translations for the login feature.

Line range hint 1226-1301: Looks good!

The signup object contains translations for the signup feature.

Line range hint 1303-1308: Looks good!

The recover object contains translations for the account recovery feature.

Line range hint 1310-1317: Looks good!

The items object contains translations for item categories.

Line range hint 1319-1369: Looks good!

The common object contains translations for common phrases and labels used throughout the application.

Line range hint 1371-1382: Looks good!

The units object contains translations for time units.

Line range hint 1384-1508: Looks good!

The play_level object contains translations for the level play feature.

Line range hint 1510-1538: Looks good!

The code object contains translations for code-related keywords and phrases.

Line range hint 1540-1550: Looks good!

The share_progress_modal object contains translations for the share progress modal.

Line range hint 1552-1565: Looks good!

The keyboard_shortcuts object contains translations for keyboard shortcut descriptions.

Line range hint 1567-1570: Looks good!

The cinematic object contains translations for the cinematic mode.

Line range hint 1572-1593: Looks good!

The community object contains translations for the community feature.

Line range hint 1595-1648: Looks good!

The clans object contains translations for the clans feature.

Line range hint 1650-1920: Looks good!

The courses object contains translations for the courses feature.

Line range hint 1922-1926: Looks good!

The project_gallery object contains translations for the project gallery feature.

Line range hint 1928-2169: Looks good!

The teacher object contains translations for the teacher dashboard and related features.

Line range hint 2171-2174: Looks good!

The teacher_licenses object contains translations for teacher licenses.

Line range hint 2176-2184: Looks good!

The teacher_ozaria_encouragement_modal object contains translations for the teacher encouragement modal for Ozaria.

Line range hint 2186-2192: Looks good!

The educator_signup_ozaria_encouragement object contains translations for the educator signup encouragement for Ozaria.

Line range hint 2194-2201: Looks good!

The ozaria_cta object contains translations for the Ozaria call-to-action.

Line range hint 2203-2235: Looks good!

The share_licenses object contains translations for the license sharing feature.

Line range hint 2237-2255: Looks good!

The sharing object contains translations for the sharing feature.

Line range hint 2257-2259: Looks good!

The game_dev object contains translations for the game development feature.

Line range hint 2261-2270: Looks good!

The web_dev object contains translations for the web development feature.

Line range hint 2272-2286: Looks good!

The classes object contains translations for the classes feature.

Line range hint 2288-2369: Looks good!

The editor object contains translations for the code editor.

Line range hint 2371-2373: Looks good!

The article object contains translations for the article editor.

Line range hint 2375-2377: Looks good!

The polls object contains translations for polls.

Line range hint 2379-2461: Looks good!

The contribute object contains translations for the contribute page.

Line range hint 2463-2470: Looks good!

The ladder_prizes object contains translations for ladder prizes. However, the comment suggests this section is outdated and doesn't need new translations.

Line range hint 2472-2483: Looks good!

The calendar object contains translations for the calendar component.

Line range hint 2485-2491: Looks good!

The code_play_create_account_modal object contains translations for the account creation modal in the code play feature.

Line range hint 2493-2500: Looks good!

The server_error object contains translations for server error messages.

Line range hint 2502-2511: Looks good!

The esper object contains translations for error messages and hints.

Line range hint 2513-2540: Looks good!

The apcsp object contains translations for the AP Computer Science Principles course.

@adamkecskes adamkecskes merged commit b4de56a into master Dec 11, 2024
2 checks passed
@adamkecskes adamkecskes deleted the adamk/read-only-view-of-ai-scenario branch December 11, 2024 09:38
@coderabbitai coderabbitai bot mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mrfinch mrfinch mrfinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkecskes @mrfinch
0