Add new logo and i18n for HS #7823
Conversation
WalkthroughThe pull request introduces extensive modifications to the localization strings in Changes
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
app/locale/en.js (4)
Line range hint
8-24: Verify translations for new entriesSeveral new translation entries have been added under the
ozaria_homenamespace, such assubtitle,heading_subtitle,item_list_p, etc.Please ensure these new English translations accurately convey the intended messaging for the Ozaria home page.
Line range hint
29-42: Review updated translationsThe translations for entries like
global_subtitle1,global_subtitle2, etc. underozaria_homehave been updated.Please review these changes to confirm they are accurate and read naturally in English.
Line range hint
44-45: Verify new translation entryA new translation
individual_users_not_supportedhas been added.Please confirm this new English message is worded appropriately to convey that Ozaria is for classrooms only.
6093-6094: New translation entries addedTwo new translation entries
editanddeletehave been added under thehackstacknamespace.Please verify these single word translations are sufficient in the context they will be used.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
app/locale/en.js(1 hunks)
🔇 Additional comments (5)
app/locale/en.js (5)
Line range hint 1-2: Looks good!
The module exports syntax is correct.
Line range hint 4-6: Translations look appropriate
The English translations for the nativeDescription and englishDescription fields are correct.
Line range hint 26-27: Translations look good
The translations for the pd_blurb entry look good, with the __pd__ placeholder used correctly.
Line range hint 47-48: Translation looks good
The translation for the accounts_merge_confirmation entry looks good.
Line range hint 50-6092: Skipped reviewing unchanged code
The code in these line ranges does not appear to have any changes. Skipping detailed review.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
app/locale/en.js (5)
Line range hint
1-6088: Standardize string interpolation syntaxThe file uses mixed string interpolation styles - both
__variable__and{variable}. For example:- diplomat_pitch_body: "We develop CodeCombat in English, but we already have players all over the world. Many of them want to play in {English} but don't speak English..." + diplomat_pitch_body: "We develop CodeCombat in English, but we already have players all over the world. Many of them want to play in __english__ but don't speak English..."Should standardize on the
__variable__syntax used by majority of strings for consistency.
Line range hint
1-6088: Standardize text formatting approachThe file mixes HTML and markdown formatting styles. For example:
- mission_description_1: "<strong>Programming is magic</strong>. It's the ability to create things from pure imagination." + mission_description_1: "**Programming is magic**. It's the ability to create things from pure imagination." - learn_more_modal: 'Teacher accounts on CodeCombat have the ability to monitor student progress, assign licenses and manage classrooms. Teacher accounts cannot be a part of a classroom - if you are currently enrolled in a class using this account, you will no longer be able to access it once you update to a Teacher Account.', + learn_more_modal: "Teacher accounts on CodeCombat have the ability to monitor student progress, assign licenses and manage classrooms.\n\nTeacher accounts cannot be a part of a classroom - if you are currently enrolled in a class using this account, you will no longer be able to access it once you update to a Teacher Account."Should standardize on markdown formatting for consistency and readability:
- Use
**text**for bold instead of<strong>- Use
[text](url)for links instead of<a>- Use newlines instead of
<br>tags
Line range hint
1-6088: Fill in missing translationsSeveral strings are missing translations or have placeholder values:
App_alt: '', faq_7_answer: 'TBA',Please provide translations for all empty strings and replace placeholder values with actual content.
Line range hint
1-6088: Fix typos and grammatical issuesFound several text quality issues:
- separated_by_comma: "Function calls paramaters must be seperated by `,`s" + separated_by_comma: "Function call parameters must be separated by commas" - error_segmentation_fault: 'Segmentation Fault `__offset__`.', + error_segmentation_fault: 'Segmentation Fault at offset `__offset__`.'Please review and correct typos, grammar, and improve readability where needed.
Line range hint
1-6088: Standardize terminology usageFound inconsistent terminology throughout the file:
- Mixed usage of "student" and "learner"
- Inconsistent capitalization of product names (e.g. "CodeCombat", "Codecombat", "codecombat")
- Varying terms for same concepts (e.g. "teacher"/"educator", "class"/"classroom")
Should establish and follow a terminology style guide to maintain consistency.
client for https://github.com/codecombat/ai/pull/300
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes