Tesla: fix convenience blinker #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the convenience blinker behavior for Tesla models by updating the conditions that determine if the left and right blinkers are active.
- Updated left blinker condition to capture multiple blinking states
- Updated right blinker condition to capture multiple blinking states
Comments suppressed due to low confidence (2)
opendbc/car/tesla/carstate.py:74
- [nitpick] Consider defining constants or an enumeration for the blinking state values (1 and 2) to improve readability and maintainability.
ret.leftBlinker = cp_party.vl["UI_warning"]["leftBlinkerBlinking"] in (1, 2)
opendbc/car/tesla/carstate.py:75
- [nitpick] Consider defining constants or an enumeration for the blinking state values (1 and 2) to improve the code clarity for right blinker logic.
ret.rightBlinker = cp_party.vl["UI_warning"]["rightBlinkerBlinking"] in (1, 2)
12 tasks
Edison-CBS
pushed a commit
to Edison-CBS/opendbc
that referenced
this pull request
Apr 5, 2025
fix convenience blinker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing signal would only describe the stalk position if the auto-cancel blinker option was disabled, in effect it would be a single frame. This now captures all states properly