Merge `main` into `feature/abci++vef` (preparation merge) #568

sergio-mena · 2023-03-23T07:50:52Z

Contributes to #10

This merge is in preparation for the final merge, which will be in the opposite direction: feature/abci++vef --> main

Performing two merges, rather than one merge in one shot, allows us resolve all existing conflicts now, do some testing, etc, without blocking commits to main: to avoid a dirty merge from feature/abci++vef to main, no commit should land on main during that merge operation. In contrast, this one only blocks commits to feature/abci++vef which is not a problem since all those commits have already landed.

Ran e2e nightly locally. All testnets passing.

Kudos to @jmalicevic for solving some of the unit test failures.

IMPORTANT: Please do not review the detail of this merge, as this code has already been reviewed on main.

PR checklist

Tests written/updated
Changelog entry added in .changelog (we use unclog to manage our changelog)
Updated relevant documentation (docs/ or spec/) and code comments

* e2e: fix Makefile to produce commit_hash for builtin * Added changelog * Revert "Added changelog" This reverts commit 6c9a683.

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove BlockSyncMode config * In e2e tests, replace BlockSync by BlockSyncVersion * Remove block_sync from toml * Update doc * Fix message * Update docs/core/block-sync.md Co-authored-by: Sergio Mena <sergio@informal.systems> * BlockSyncVersion cannot be empty --------- Co-authored-by: Sergio Mena <sergio@informal.systems>

…463) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.40.0 to 0.41.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.40.0...v0.41.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>

…465) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.20.2 to 2.21.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p> <blockquote> <h2>v2.21.1</h2> <h2>Changelog</h2> <ul> <li>b97f667 Add social cards</li> <li>c2a3cb6 Fix regression with legacy config</li> <li>72554ce Merge branch 'master' into cards</li> <li>a7cf7ac Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/557">#557</a> from LandonTClipp/cards</li> <li>d0267e6 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/559">#559</a> from LandonTClipp/docs</li> <li>020ddf5 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/560">#560</a> from LandonTClipp/bugfix</li> <li>305f09e Update changelog.md</li> <li>91eb221 Update changelog.md</li> <li>bafd3dd Update changelog.md</li> <li>d9a775e Update changelog.md</li> <li>054efa4 Update features.md</li> <li>8fb431a Update features.md</li> <li>7640bc1 Update features.md</li> <li>ddb84b3 Update mkdocs.yml</li> <li>49057c4 Update mkdocs.yml</li> <li>e3a9138 Update static.yml</li> <li>2aaf163 Update static.yml</li> <li>3063f77 adjust CI/CD</li> <li>588d7c6 update to docs</li> </ul> <h2>v2.21.0</h2> <h2>Changelog</h2> <ul> <li>ce72781 Add documentation</li> <li>2ad198f Create codecov.yml</li> <li>39ae11a Dramatically increase mock generation speed</li> <li>733277b Fix incorrect Makefile</li> <li>82bc0c1 Fixing if statement</li> <li>16546bb Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/548">#548</a> from LandonTClipp/i_am_speed</li> <li>02edbfe Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/556">#556</a> from vektra/LandonTClipp-patch-1</li> <li>9dadb97 Remove unused mocks</li> <li>c034dde Reshuffle some logic</li> <li>8a82d41 Restructure config</li> <li>9963671 Update features.md</li> <li>757027c Update features.md</li> <li>e057edd update docs</li> <li>b7dab32 update docs</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vektra/mockery/commit/020ddf551703fe26d991a3e4acef156e2051fe52"><code>020ddf5</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/560">#560</a> from LandonTClipp/bugfix</li> <li><a href="https://github.com/vektra/mockery/commit/c2a3cb69da0bc1664c17499e4c64728eaf29a9c5"><code>c2a3cb6</code></a> Fix regression with legacy config</li> <li><a href="https://github.com/vektra/mockery/commit/d0267e65639124ab6173a442659ede14e42e577c"><code>d0267e6</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/559">#559</a> from LandonTClipp/docs</li> <li><a href="https://github.com/vektra/mockery/commit/588d7c672fc8619dbcbc48d46d02d283eba4b19d"><code>588d7c6</code></a> update to docs</li> <li><a href="https://github.com/vektra/mockery/commit/8fb431afba156731b5008878accb3d8f6937c6ff"><code>8fb431a</code></a> Update features.md</li> <li><a href="https://github.com/vektra/mockery/commit/ddb84b392de30033e003861a68777ef0c06d71dd"><code>ddb84b3</code></a> Update mkdocs.yml</li> <li><a href="https://github.com/vektra/mockery/commit/305f09e92310b41bbf65a088e36495c3db06ba82"><code>305f09e</code></a> Update changelog.md</li> <li><a href="https://github.com/vektra/mockery/commit/054efa45d16f5348723d55109371cae15ab5b1f6"><code>054efa4</code></a> Update features.md</li> <li><a href="https://github.com/vektra/mockery/commit/e3a91384dd60aa22b913a04d4ea09e7cc7380eb1"><code>e3a9138</code></a> Update static.yml</li> <li><a href="https://github.com/vektra/mockery/commit/2aaf1634a6ac3f67d69ad4a4f19298a88ddf9ef4"><code>2aaf163</code></a> Update static.yml</li> <li>Additional commits viewable in <a href="https://github.com/vektra/mockery/compare/v2.20.2...v2.21.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.20.2&new-version=2.21.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.14.0 to 1.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/releases">github.com/bufbuild/buf's releases</a>.</em></p> <blockquote> <h2>v1.15.0</h2> <ul> <li>Update built-in Well-Known Types to Protobuf v22.0.</li> <li>Fixes a bug in <code>buf format</code> where C-style block comments in which every line includes a prefix (usually "*") would be incorrectly indented.</li> <li>Add <code>--private-network</code> flag to <code>buf beta studio-agent</code> to support handling CORS requests from Studio on private networks that set the <code>Access-Control-Request-Private-Network</code> header.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/blob/main/CHANGELOG.md">github.com/bufbuild/buf's changelog</a>.</em></p> <blockquote> <h2>[v1.15.0] - 2023-02-28</h2> <ul> <li>Update built-in Well-Known Types to Protobuf v22.0.</li> <li>Fixes a bug in <code>buf format</code> where C-style block comments in which every line includes a prefix (usually "*") would be incorrectly indented.</li> <li>Add <code>--private-network</code> flag to <code>buf beta studio-agent</code> to support handling CORS requests from Studio on private networks that set the <code>Access-Control-Request-Private-Network</code> header.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf/commit/a0ffc318d04fe8de1e2e04b73ff7a135d67c5442"><code>a0ffc31</code></a> Release v1.15.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1866">#1866</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/0f75e26260f8003385224913e133a771f364e421"><code>0f75e26</code></a> Add user activated type to events proto (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1864">#1864</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/e15702f7ee8f03aee98b744e508fba0d36d1daaa"><code>e15702f</code></a> Update cache to use tamper proofing (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1847">#1847</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/4f2c902f4b856dbf59c6aee80a5f67810ed15079"><code>4f2c902</code></a> Handle private network preflight requests in Studio agent with flag `--privat...</li> <li><a href="https://github.com/bufbuild/buf/commit/7ccff88b99863f969bcc0367577198d3082b1f19"><code>7ccff88</code></a> Bump github.com/jhump/protoreflect from 1.14.1 to 1.15.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1862">#1862</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/52c2655731bf264cc867f5a92b927ef68983fce5"><code>52c2655</code></a> Bump github.com/klauspost/compress from 1.15.15 to 1.16.0 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1860">#1860</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/309d0f66447b6717231b3a12c1fb178ac25bf8e2"><code>309d0f6</code></a> Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1861">#1861</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/2f625eabbf909faa415bba30c8f7f96155b736e7"><code>2f625ea</code></a> Fix formatting of C-style block comments that use prefix symbols on each line...</li> <li><a href="https://github.com/bufbuild/buf/commit/d477ec23f96ccbb27ed09370ea8df866b61f8d0c"><code>d477ec2</code></a> More pkg/manifest documentation (<a href="https://github-redirect.dependabot.com/bufbuild/buf/issues/1854">#1854</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/83ee368af9cd65042fecedb0520e6fa63c23a6e6"><code>83ee368</code></a> Preserve unknown fields when converting between <code>FileDescriptorProto</code> and `Im...</li> <li>Additional commits viewable in <a href="https://github.com/bufbuild/buf/compare/v1.14.0...v1.15.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/bufbuild/buf&package-manager=go_modules&previous-version=1.14.0&new-version=1.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Link checking will soon happen from the CometBFT docs repo, as per cometbft/cometbft-docs#54. Already, the Jekyll build restructures the documentation, resulting in broken links in Markdown that will be correctly rendered only once deployed to the docs site (e.g. the `/spec` directory is moved into `/docs/spec`, and the `rpc/openapi/*` contents are moved into `/docs/rpc/` during the build for each version of the docs). --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.5.2 to 5.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/go-git/go-git/releases">github.com/go-git/go-git/v5's releases</a>.</em></p> <blockquote> <h2>v5.6.0</h2> <h2>What's Changed</h2> <ul> <li>Worktree, check for empty parent dirs during Reset (Fixes <a href="https://github-redirect.dependabot.com/go-git/go-git/issues/670">#670</a>) by <a href="https://github.com/mbohy"><code>@mbohy</code></a> in <a href="https://github-redirect.dependabot.com/go-git/go-git/pull/671">go-git/go-git#671</a></li> <li>*: remove need to build with CGO by <a href="https://github.com/pjbgf"><code>@pjbgf</code></a> in <a href="https://github-redirect.dependabot.com/go-git/go-git/pull/688">go-git/go-git#688</a></li> <li>plumbing: support SSH/X509 signed tags by <a href="https://github.com/hiddeco"><code>@hiddeco</code></a> in <a href="https://github-redirect.dependabot.com/go-git/go-git/pull/690">go-git/go-git#690</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/go-git/go-git/compare/v5.5.2...v5.6.0">https://github.com/go-git/go-git/compare/v5.5.2...v5.6.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/go-git/go-git/commit/b826c51299a84a2a6b191e98172b57b2a53fcf60"><code>b826c51</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/go-git/go-git/issues/690">#690</a> from hiddeco/recognize-tag-signatures</li> <li><a href="https://github.com/go-git/go-git/commit/2401659b649ff6d386383ec06c4b9d5290b2741c"><code>2401659</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/go-git/go-git/issues/688">#688</a> from pjbgf/bump-sha1cd</li> <li><a href="https://github.com/go-git/go-git/commit/f1dc529fac28e6c45882292184270f94b5d30b7f"><code>f1dc529</code></a> plumbing: support SSH/X509 signed tags</li> <li><a href="https://github.com/go-git/go-git/commit/bd33c95fc3cbe8c04dd084c22defd1aa3c3e43dc"><code>bd33c95</code></a> Remove need to build with CGO</li> <li><a href="https://github.com/go-git/go-git/commit/7ab4957732a817bada223e5c361f0c9753d9e40c"><code>7ab4957</code></a> ci: update go version</li> <li><a href="https://github.com/go-git/go-git/commit/f848aaf02ab0cb9a41cef3f457c45a93e2265d76"><code>f848aaf</code></a> git: worktree: check for empty parent dirs during Reset (Fixes <a href="https://github-redirect.dependabot.com/go-git/go-git/issues/670">#670</a>) (<a href="https://github-redirect.dependabot.com/go-git/go-git/issues/671">#671</a>)</li> <li>See full diff in <a href="https://github.com/go-git/go-git/compare/v5.5.2...v5.6.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/go-git/go-git/v5&package-manager=go_modules&previous-version=5.5.2&new-version=5.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.8.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/dfa2b5dffd96fb2ae13e7d182501f0bce044a0a4"><code>dfa2b5d</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/net/commit/8c4ef2f86b571fd6b859ef409ccf05284e852214"><code>8c4ef2f</code></a> hmtl: add security section to package comment</li> <li><a href="https://github.com/golang/net/commit/1d46ed8b487a394ccf6d67de0a95b76ebc0b8aba"><code>1d46ed8</code></a> html: have Render escape comments less often</li> <li><a href="https://github.com/golang/net/commit/569fe8158ca38ebec97f9307039772123dc6a98f"><code>569fe81</code></a> html: add "Microsoft Outlook comment" tests</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.7.0...v0.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.7.0&new-version=0.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

This reverts commit 06eeaaa.

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.6.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/crypto/commit/776e461a4e6d8b372a43c72122c5c28cfc40dca2"><code>776e461</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/crypto/commit/ebe92624d1428c68f92576e1d27cc65d62bc2f7e"><code>ebe9262</code></a> ssh: add support for <a href="mailto:aes256-gcm@openssh.com">aes256-gcm@openssh.com</a></li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.6.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/crypto&package-manager=go_modules&previous-version=0.6.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

For some reason this topic keeps coming up and I'd like us to emphasize this part of the documentation to put this topic to rest. Operators are, and have always been, ultimately responsible for securing their RPC endpoints if they choose to make them available publicly. [Rendered](https://github.com/cometbft/cometbft/blob/thane/docs/rpc-production/docs/core/running-in-production.md#rpc) --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

* Moves all guides to a guids folder * Moves the actual intro to the README.md of the intro folder * Add guides to the guide README.md * Fixing links in docs/README.md

…s and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.4.1 to 2.5.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.4.1...v2.5.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.15.0 to 1.15.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/00661b48f00bf682921f8aab99306c7f1a7a3ec3"><code>00661b4</code></a> Release v1.15.1 (<a href="https://redirect.github.com/bufbuild/buf-setup-action/issues/112">#112</a>)</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.15.0...v1.15.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.15.0&new-version=1.15.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.15.0 to 1.15.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/releases">github.com/bufbuild/buf's releases</a>.</em></p> <blockquote> <h2>v1.15.1</h2> <ul> <li>Fix a bug in <code>buf generate</code> with <code>v1beta1</code> config files.</li> <li>Fix a potential crash when using the <code>--type</code> flag with <code>buf build</code> or <code>buf generate</code>.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf/blob/main/CHANGELOG.md">github.com/bufbuild/buf's changelog</a>.</em></p> <blockquote> <h2>[v1.15.1] - 2023-03-08</h2> <ul> <li>Fix a bug in <code>buf generate</code> with <code>v1beta1</code> config files.</li> <li>Fix a potential crash when using the <code>--type</code> flag with <code>buf build</code> or <code>buf generate</code>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf/commit/5d924a674cf977ab6e1994f127046ef6880aaaa2"><code>5d924a6</code></a> Release v1.15.1 (<a href="https://redirect.github.com/bufbuild/buf/issues/1899">#1899</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/691f3b55a66ab64be3a5253e77c44beed836eae6"><code>691f3b5</code></a> Update to protoc-gen-go v1.29.0 and make upgrade (<a href="https://redirect.github.com/bufbuild/buf/issues/1898">#1898</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/246f55140952e2dc9365a48b35ca16576c8375cb"><code>246f551</code></a> Make upgrade (<a href="https://redirect.github.com/bufbuild/buf/issues/1891">#1891</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/c2bac3f18d4daf7e7def4cdc2f97f8a520bb3f3d"><code>c2bac3f</code></a> Clarify that format takes a source and not an input (<a href="https://redirect.github.com/bufbuild/buf/issues/1895">#1895</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/d29581309df892c07f9aff6d6219f64e632ff0cf"><code>d295813</code></a> Add note about recent crash fix to change log (<a href="https://redirect.github.com/bufbuild/buf/issues/1894">#1894</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/a14e31107db0114e8f38ddd5c0761d5b87990c0b"><code>a14e311</code></a> Only assign plugin path if set in config (<a href="https://redirect.github.com/bufbuild/buf/issues/1893">#1893</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/bdbb114d40a48c8ad1ec83204aa1155845ddd745"><code>bdbb114</code></a> Update gofrs/uuid to new version supporting modules (<a href="https://redirect.github.com/bufbuild/buf/issues/1880">#1880</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/2b07af3b7c6951af580bd5db7bbde05f12c5be8f"><code>2b07af3</code></a> Bump bufbuild/buf-setup-action from 1.14.0 to 1.15.0 (<a href="https://redirect.github.com/bufbuild/buf/issues/1885">#1885</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/feda532ebfab81f07e1338d8808a548d14dbc959"><code>feda532</code></a> Teeny-tiny updates in buf curl (<a href="https://redirect.github.com/bufbuild/buf/issues/1882">#1882</a>)</li> <li><a href="https://github.com/bufbuild/buf/commit/c7d177030f3a3cad13d16e2903361f27799cf337"><code>c7d1770</code></a> Add manifest digest field to repo commit (<a href="https://redirect.github.com/bufbuild/buf/issues/1877">#1877</a>)</li> <li>Additional commits viewable in <a href="https://github.com/bufbuild/buf/compare/v1.15.0...v1.15.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/bufbuild/buf&package-manager=go_modules&previous-version=1.15.0&new-version=1.15.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…506) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.21.1 to 2.22.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p> <blockquote> <h2>v2.22.1</h2> <h2>Changelog</h2> <ul> <li>1f08b60 Add additional cases to InterfaceName template variable</li> <li>32917d4 Add more documentation for template variables</li> <li>ddd193c Add more variables available for templating, update docs</li> <li>c96741b Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/578">#578</a> from LandonTClipp/interface_case</li> </ul> <h2>v2.22.0</h2> <h2>Changelog</h2> <ul> <li>b61e29c Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/569">#569</a> from hikyaru-suzuki/feature/add_struct_tag</li> <li>482013c add: impl struct tag</li> <li>fab0e95 add: test</li> <li>f39cd74 fix: go mod tidy</li> <li>dd639a3 fix: review</li> <li>c66831a update: refactor</li> <li>783a82a update: refactor</li> <li>c8f12f0 update: rename</li> </ul> <h2>v2.21.6</h2> <h2>Changelog</h2> <ul> <li>61d7db1 Add <code>InterfaceDir</code> template variable</li> <li>284fce2 Add note about <code>InterfaceDir</code> template variable</li> <li>1234a24 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/576">#576</a> from LandonTClipp/issue_574</li> </ul> <h2>v2.21.5</h2> <h2>Changelog</h2> <ul> <li>cd10413 Fix issue with global defaults having no effect</li> <li>e478c25 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/573">#573</a> from LandonTClipp/issue_571</li> </ul> <h2>v2.21.4</h2> <h2>Changelog</h2> <ul> <li>668d432 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/570">#570</a> from xonvanetta/bugfix/568</li> <li>dd54fc8 fix: don't override c.Dir when it's set</li> </ul> <h2>v2.21.3</h2> <h2>Changelog</h2> <ul> <li>c3c0530 Add danger message to docs for <code>packages</code> feature</li> <li>743d11c Add test for empty/bad packages config</li> <li>4601062 Fix bug when parsing packages config</li> <li>1f04222 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/567">#567</a> from LandonTClipp/issue_565</li> <li>660b7f9 Update features.md</li> <li>86617b1 fix tests with config</li> </ul> <h2>v2.21.2</h2> <h2>Changelog</h2> <ul> <li>425570a Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/566">#566</a> from LandonTClipp/config_warn</li> <li>9a12a12 Remove warning message for absent config file</li> <li>62dcb4b Update index.md</li> <li>d9b8b36 Update index.md</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vektra/mockery/commit/c96741badaef67a896a80e9e68ce42d8526cddce"><code>c96741b</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/578">#578</a> from LandonTClipp/interface_case</li> <li><a href="https://github.com/vektra/mockery/commit/32917d4a33bebd68fde1538da30645894009e344"><code>32917d4</code></a> Add more documentation for template variables</li> <li><a href="https://github.com/vektra/mockery/commit/ddd193c7db8d94275f03a150ce55ebcd34627fbc"><code>ddd193c</code></a> Add more variables available for templating, update docs</li> <li><a href="https://github.com/vektra/mockery/commit/1f08b6089adfe4bd66ad72decd05dac289dc1538"><code>1f08b60</code></a> Add additional cases to InterfaceName template variable</li> <li><a href="https://github.com/vektra/mockery/commit/b61e29c5f5e162489c752c27eb24b968b3d4f17e"><code>b61e29c</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/569">#569</a> from hikyaru-suzuki/feature/add_struct_tag</li> <li><a href="https://github.com/vektra/mockery/commit/284fce29129939d8337d29033131d60c7549ec16"><code>284fce2</code></a> Add note about <code>InterfaceDir</code> template variable</li> <li><a href="https://github.com/vektra/mockery/commit/1234a24ae4fe02812c66fc54f4df61c1b30ea687"><code>1234a24</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/576">#576</a> from LandonTClipp/issue_574</li> <li><a href="https://github.com/vektra/mockery/commit/61d7db16cd4b4b336e538f1af1fc26d02fa0d3ae"><code>61d7db1</code></a> Add <code>InterfaceDir</code> template variable</li> <li><a href="https://github.com/vektra/mockery/commit/dd639a33c2a928c151d31dbfb237a27e30a1a7c7"><code>dd639a3</code></a> fix: review</li> <li><a href="https://github.com/vektra/mockery/commit/c66831a54abf60fbc2094e2955795b6dd2737ec2"><code>c66831a</code></a> update: refactor</li> <li>Additional commits viewable in <a href="https://github.com/vektra/mockery/compare/v2.21.1...v2.22.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.21.1&new-version=2.22.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…3303-bc1253ad3743 to 1.29.1 (#527) Bumps google.golang.org/protobuf from 1.28.2-0.20230222093303-bc1253ad3743 to 1.29.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/protobuf&package-manager=go_modules&previous-version=1.28.2-0.20230222093303-bc1253ad3743&new-version=1.29.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* fix(readme.md): update the links for guides install guides; single node quick start guides; * Apply suggestions from code review --------- Co-authored-by: Lasaro <lasaro@gmail.com> Co-authored-by: Lasaro <lasaro@informal.systems>

…507) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.41.0 to 0.42.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/common/releases">github.com/prometheus/common's releases</a>.</em></p> <blockquote> <h2>v0.42.0</h2> <h2>What's Changed</h2> <ul> <li>Parse Durations much faster by <a href="https://github.com/bboreham"><code>@bboreham</code></a> in <a href="https://redirect.github.com/prometheus/common/pull/461">prometheus/common#461</a></li> <li>version: add Go build tags to output by <a href="https://github.com/bboreham"><code>@bboreham</code></a> in <a href="https://redirect.github.com/prometheus/common/pull/455">prometheus/common#455</a></li> <li>Add support to use Proxy From Environment by <a href="https://github.com/roidelapluie"><code>@roidelapluie</code></a> in <a href="https://redirect.github.com/prometheus/common/pull/462">prometheus/common#462</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/bboreham"><code>@bboreham</code></a> made their first contribution in <a href="https://redirect.github.com/prometheus/common/pull/461">prometheus/common#461</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/prometheus/common/compare/v0.41.0...v0.42.0">https://github.com/prometheus/common/compare/v0.41.0...v0.42.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/common/commit/66b493f42b757378fbad83e42b0ed441d425a17b"><code>66b493f</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/common/issues/462">#462</a> from roidelapluie/proxyfromenv</li> <li><a href="https://github.com/prometheus/common/commit/c8ca1fb738e578a3788ee852fdc8e8c3961fae6d"><code>c8ca1fb</code></a> Add support to use Proxy From Environment and set No Proxy</li> <li><a href="https://github.com/prometheus/common/commit/6a5f4db5f3194094906b9c9a37b876b73a8b7aa8"><code>6a5f4db</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/common/issues/455">#455</a> from bboreham/build-tags</li> <li><a href="https://github.com/prometheus/common/commit/d7d98af2eded4575b475044270678b28d101ee99"><code>d7d98af</code></a> Merge pull request <a href="https://redirect.github.com/prometheus/common/issues/461">#461</a> from bboreham/faster-parseduration</li> <li><a href="https://github.com/prometheus/common/commit/55b01d164325a0154b3cc1559dc534542e7faa1f"><code>55b01d1</code></a> Parse Durations much faster</li> <li><a href="https://github.com/prometheus/common/commit/330a3f525e6d449501b16a6b119af32457cc4ffc"><code>330a3f5</code></a> Add benchmark for ParseDuration</li> <li><a href="https://github.com/prometheus/common/commit/56d83af4bcb1a150aa987dec7d02fb77d0ba5deb"><code>56d83af</code></a> version: add Go build tags to output</li> <li>See full diff in <a href="https://github.com/prometheus/common/compare/v0.41.0...v0.42.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/prometheus/common&package-manager=go_modules&previous-version=0.41.0&new-version=0.42.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

In (*PeerState).PickSendVote, there is a Debug-level log that includes the PeerState value as a logging field. By default, zerolog json-encodes a struct passed as a log field (when the struct doesn't implement zerolog.LogObjectMarshaler). Because PeerState didn't have a MarshalJSON method, the JSON encoder fell back to reflection to encode the PeerState value. Reflection did not acquire the lock, and there were data races resulting from an unsynchronized read while logging the PeerState, and concurrent (locked) writes at least during (*PeerState).SetHasProposal and (*PeerState).SetHasVote. Given that there was only one call to (*PeerState).ToJSON in the cometbft repo, it seemed appropriate to just rename ToJSON to MarshalJSON, as opposed to leaving ToJSON for backwards compatibility. Any third party calls to ToJSON should be able to easily change the method being called. Example data race (which is no longer reproducible with this change): ``` ================== WARNING: DATA RACE Read at 0x00c0004a4870 by goroutine 131: reflect.Value.Bool() /opt/homebrew/Cellar/go/1.20.1/libexec/src/reflect/value.go:288 +0x7c encoding/json.boolEncoder() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:539 +0x88 encoding/json.structEncoder.encode() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:759 +0x1bc encoding/json.structEncoder.encode-fm() <autogenerated>:1 +0x94 encoding/json.structEncoder.encode() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:759 +0x1bc encoding/json.structEncoder.encode-fm() <autogenerated>:1 +0x94 encoding/json.ptrEncoder.encode() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:943 +0x2a4 encoding/json.ptrEncoder.encode-fm() <autogenerated>:1 +0x6c encoding/json.(*encodeState).reflectValue() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:358 +0x74 encoding/json.(*encodeState).marshal() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:330 +0x1a0 encoding/json.Marshal() /opt/homebrew/Cellar/go/1.20.1/libexec/src/encoding/json/encode.go:161 +0xa0 github.com/rs/zerolog.init.1.func1() /Users/hh/go/pkg/mod/github.com/rs/zerolog@v1.29.0/encoder_json.go:21 +0x4c github.com/rs/zerolog/internal/json.Encoder.AppendInterface() /Users/hh/go/pkg/mod/github.com/rs/zerolog@v1.29.0/internal/json/types.go:366 +0x5c github.com/rs/zerolog.appendFieldList() /Users/hh/go/pkg/mod/github.com/rs/zerolog@v1.29.0/fields.go:273 +0x2b8c github.com/rs/zerolog.appendFields() /Users/hh/go/pkg/mod/github.com/rs/zerolog@v1.29.0/fields.go:21 +0x160 github.com/rs/zerolog.(*Event).Fields() /Users/hh/go/pkg/mod/github.com/rs/zerolog@v1.29.0/event.go:165 +0x90 cosmossdk.io/log.zeroLogWrapper.Debug() /Users/hh/go/pkg/mod/cosmossdk.io/log@v0.0.0-20230313123454-0fe816b71a62/logger.go:89 +0x18 github.com/cosmos/cosmos-sdk/server/log.(*CometZeroLogWrapper).Debug() <autogenerated>:1 +0x74 github.com/cometbft/cometbft/consensus.(*PeerState).PickSendVote() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:1138 +0x1bc github.com/cometbft/cometbft/consensus.(*Reactor).gossipVotesForHeight() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:794 +0x260 github.com/cometbft/cometbft/consensus.(*Reactor).gossipVotesRoutine() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:724 +0x2cc github.com/cometbft/cometbft/consensus.(*Reactor).AddPeer.func2() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:199 +0x58 Previous write at 0x00c0004a4870 by goroutine 130: github.com/cometbft/cometbft/consensus.(*PeerState).SetHasProposal() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:1096 +0x118 github.com/cometbft/cometbft/consensus.(*Reactor).gossipDataRoutine() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:617 +0xab8 github.com/cometbft/cometbft/consensus.(*Reactor).AddPeer.func1() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:198 +0x58 Goroutine 131 (running) created at: github.com/cometbft/cometbft/consensus.(*Reactor).AddPeer() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:199 +0x240 github.com/cometbft/cometbft/p2p.(*Switch).addPeer() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:855 +0x7b4 github.com/cometbft/cometbft/p2p.(*Switch).acceptRoutine() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:707 +0x704 github.com/cometbft/cometbft/p2p.(*Switch).OnStart.func1() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:241 +0x34 Goroutine 130 (running) created at: github.com/cometbft/cometbft/consensus.(*Reactor).AddPeer() /Users/hh/go/src/github.com/cometbft/cometbft/consensus/reactor.go:198 +0x164 github.com/cometbft/cometbft/p2p.(*Switch).addPeer() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:855 +0x7b4 github.com/cometbft/cometbft/p2p.(*Switch).acceptRoutine() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:707 +0x704 github.com/cometbft/cometbft/p2p.(*Switch).OnStart.func1() /Users/hh/go/src/github.com/cometbft/cometbft/p2p/switch.go:241 +0x34 ================== ``` --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

Updates our root [changelog](https://github.com/cometbft/cometbft/blob/thane/post-release-docs-update/CHANGELOG.md) and [upgrading guidelines](https://github.com/cometbft/cometbft/blob/thane/post-release-docs-update/UPGRADING.md) on `main` to sync them with what we have on `v0.34.x` and `v0.37.x`. Also makes a few minor changes to the [README](https://github.com/cometbft/cometbft/blob/thane/post-release-docs-update/README.md). --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

1. `InitialHeight` is specified twice 2. The contents of `Execute` refer to the parameter `state` not `s`

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-go/releases">actions/setup-go's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <p>In scope of release we enable cache by default. The action won’t throw an error if the cache can’t be restored or saved. The action will throw a warning message but it won’t stop a build process. The cache can be disabled by specifying <code>cache: false</code>.</p> <pre lang="yaml"><code>steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: go-version: ‘1.19’ - run: go run hello.go </code></pre> <p>Besides, we introduce such changes as</p> <ul> <li><a href="https://redirect.github.com/actions/setup-go/pull/305">Allow to use only GOCACHE for cache</a></li> <li><a href="https://redirect.github.com/actions/setup-go/pull/315">Bump json5 from 2.2.1 to 2.2.3</a></li> <li><a href="https://redirect.github.com/actions/setup-go/pull/323">Use proper version for primary key in cache</a></li> <li><a href="https://redirect.github.com/actions/setup-go/pull/351">Always add Go bin to the PATH</a></li> <li><a href="https://redirect.github.com/actions/setup-go/pull/350">Add step warning if go-version input is empty</a></li> </ul> <h2>Add support for stable and oldstable aliases</h2> <p>In scope of this release we introduce aliases for the <code>go-version</code> input. The <code>stable</code> alias instals the latest stable version of Go. The <code>oldstable</code> alias installs previous latest minor release (the stable is 1.19.x -> the oldstable is 1.18.x).</p> <h3>Stable</h3> <pre lang="yaml"><code>steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: go-version: 'stable' - run: go run hello.go </code></pre> <h3>OldStable</h3> <pre lang="yaml"><code>steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: go-version: 'oldstable' - run: go run hello.go </code></pre> <h2>Add support for go.work and pass the token input through on GHES</h2> <p>In scope of this release we added <a href="https://redirect.github.com/actions/setup-go/pull/283">support for go.work file to pass it in go-version-file input</a>.</p> <pre lang="yaml"><code>steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 </tr></table> </code></pre> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-go/commit/4d34df0c2316fe8122ab82dc22947d607c0c91f9"><code>4d34df0</code></a> Update configuration files (<a href="https://redirect.github.com/actions/setup-go/issues/348">#348</a>)</li> <li><a href="https://github.com/actions/setup-go/commit/fdc0d672a12b8fc05ef4c549c3fd5b0f03ebeb4c"><code>fdc0d67</code></a> Add Go bin if go-version input is empty (<a href="https://redirect.github.com/actions/setup-go/issues/351">#351</a>)</li> <li><a href="https://github.com/actions/setup-go/commit/ebfdf6ac95bce0e7e743a60aba7adf59b400885b"><code>ebfdf6a</code></a> add warning if go-version is empty (<a href="https://redirect.github.com/actions/setup-go/issues/350">#350</a>)</li> <li><a href="https://github.com/actions/setup-go/commit/b27d76912e7cb72b7262b5be2ec903b6cfaf358a"><code>b27d769</code></a> fix lockfileVersion (<a href="https://redirect.github.com/actions/setup-go/issues/349">#349</a>)</li> <li><a href="https://github.com/actions/setup-go/commit/c51a7207680f1bee06f4a751214aab70667f9e25"><code>c51a720</code></a> Enable caching by default with default input (<a href="https://redirect.github.com/actions/setup-go/issues/332">#332</a>)</li> <li><a href="https://github.com/actions/setup-go/commit/6b848af622919e18822928df24a57044dc6ea9ab"><code>6b848af</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-go/issues/343">#343</a> from akv-platform/reusable-workflow</li> <li><a href="https://github.com/actions/setup-go/commit/12741cc20952a981105f1dc8366d69f1d24ed472"><code>12741cc</code></a> Format update-config-files.yml</li> <li><a href="https://github.com/actions/setup-go/commit/7a77a6aab66a15178e313f5908f5ed9b8500894c"><code>7a77a6a</code></a> Merge branch 'main' into reusable-workflow</li> <li><a href="https://github.com/actions/setup-go/commit/42a0cc8e1491c14a0e9486c3a895d2124f51af1a"><code>42a0cc8</code></a> Add update-config-files.yml</li> <li><a href="https://github.com/actions/setup-go/commit/7406d654ad8f517886f6c77135494c2b99355381"><code>7406d65</code></a> Add and configure ESLint and update configuration for Prettier (<a href="https://redirect.github.com/actions/setup-go/issues/341">#341</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/setup-go/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-go&package-manager=github_actions&previous-version=3&new-version=4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

) Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.29.1 to 1.30.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/protocolbuffers/protobuf-go/releases">google.golang.org/protobuf's releases</a>.</em></p> <blockquote> <h2>v1.30.0</h2> <ul> <li><a href="https://github.com/protocolbuffers/protobuf-go/blob/HEAD/#v1.30.0-notable-changes">Notable changes</a></li> </ul> <p><strong>Announcement</strong> In the previous two releases, v1.29.0 and v1.29.1, we associated the tags with the wrong commits and thus the tags do not reference any commit in this repository. This tag, v1.30.0, refers to an existing commit again. Sorry for the inconvenience.</p> <h2>Notable changes </h2> <p><strong>New Features</strong></p> <ul> <li><a href="https://go.dev/cl/449576">CL/449576</a>: protoadapt: helper functions to convert v1 or v2 message to either v1 or v2 message.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/protocolbuffers/protobuf-go/commit/f221882bfb484564f1714ae05f197dea2c76898d"><code>f221882</code></a> all: release v1.30.0</li> <li><a href="https://github.com/protocolbuffers/protobuf-go/commit/e344383da66ac9cf11000f824674793a77fc7d7e"><code>e344383</code></a> protoadapt: helper functions to convert v1 or v2 message to either v1 or v2 m...</li> <li><a href="https://github.com/protocolbuffers/protobuf-go/commit/32efccd1582255f0ef48bcc3942484e81985c76b"><code>32efccd</code></a> all: start v1.29.1-devel</li> <li><a href="https://github.com/protocolbuffers/protobuf-go/commit/771d8c7a1eefbd21bf7db08ec6967fed9ff9d704"><code>771d8c7</code></a> all: release v1.29.1</li> <li>See full diff in <a href="https://github.com/protocolbuffers/protobuf-go/compare/v1.29.1...v1.30.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/protobuf&package-manager=go_modules&previous-version=1.29.1&new-version=1.30.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…52.0 (#552) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.2 to 1.52.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p> <blockquote> <h2>v1.52.0</h2> <h2>Changelog</h2> <ul> <li>530ac9cf build(deps): bump github.com/Abirdcfly/dupword from 0.0.9 to 0.0.11 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3685">#3685</a>)</li> <li>b88bb978 build(deps): bump github.com/Antonboom/errname from 0.1.7 to 0.1.8 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3660">#3660</a>)</li> <li>a823b3f1 build(deps): bump github.com/Antonboom/errname from 0.1.8 to 0.1.9 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3672">#3672</a>)</li> <li>4e1f615e build(deps): bump github.com/Antonboom/nilnil from 0.1.1 to 0.1.2 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3658">#3658</a>)</li> <li>c6231164 build(deps): bump github.com/Antonboom/nilnil from 0.1.2 to 0.1.3 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3679">#3679</a>)</li> <li>3a1f50d1 build(deps): bump github.com/ashanbrown/forbidigo from 1.4.0 to 1.5.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3639">#3639</a>)</li> <li>a68dc433 build(deps): bump github.com/breml/bidichk from 0.2.3 to 0.2.4 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3680">#3680</a>)</li> <li>767060f2 build(deps): bump github.com/breml/errchkjson from 0.3.0 to 0.3.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3684">#3684</a>)</li> <li>73c0b5ec build(deps): bump github.com/charithe/durationcheck from 0.0.9 to 0.0.10 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3661">#3661</a>)</li> <li>6aa4e0f5 build(deps): bump github.com/daixiang0/gci from 0.9.1 to 0.10.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3686">#3686</a>)</li> <li>36a26718 build(deps): bump github.com/fatih/color from 1.14.1 to 1.15.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3681">#3681</a>)</li> <li>e27b129e build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3701">#3701</a>)</li> <li>ca5738e1 build(deps): bump github.com/junk1tm/musttag from 0.4.5 to 0.5.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3624">#3624</a>)</li> <li>737f3e23 build(deps): bump github.com/kkHAIKE/contextcheck from 1.1.3 to 1.1.4 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3693">#3693</a>)</li> <li>97ca788e build(deps): bump github.com/maratori/testpackage from 1.1.0 to 1.1.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3676">#3676</a>)</li> <li>77d398e6 build(deps): bump github.com/mgechev/revive from 1.2.5 to 1.3.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3698">#3698</a>)</li> <li>ca9e2107 build(deps): bump github.com/mgechev/revive from 1.3.0 to 1.3.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3702">#3702</a>)</li> <li>a76f37c1 build(deps): bump github.com/moricho/tparallel from 0.2.1 to 0.3.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3687">#3687</a>)</li> <li>49ce80ae build(deps): bump github.com/nunnatsa/ginkgolinter from 0.8.1 to 0.9.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3643">#3643</a>)</li> <li>f0dbc757 build(deps): bump github.com/polyfloyd/go-errorlint from 1.1.0 to 1.2.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3636">#3636</a>)</li> <li>ccf80255 build(deps): bump github.com/polyfloyd/go-errorlint from 1.2.0 to 1.3.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3675">#3675</a>)</li> <li>1368d92e build(deps): bump github.com/polyfloyd/go-errorlint from 1.3.0 to 1.4.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3695">#3695</a>)</li> <li>e09c247e build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.1 to 3.23.2 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3659">#3659</a>)</li> <li>a4d2362d build(deps): bump github.com/sonatard/noctx from 0.0.1 to 0.0.2 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3696">#3696</a>)</li> <li>a3cc9c2e build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3637">#3637</a>)</li> <li>11c2aed7 build(deps): bump github.com/tdakkota/asciicheck from 0.1.1 to 0.2.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3694">#3694</a>)</li> <li>7d1255df build(deps): bump github.com/timonwong/loggercheck from 0.9.3 to 0.9.4 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3657">#3657</a>)</li> <li>3af8234c build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.0 to 2.8.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3640">#3640</a>)</li> <li>67925097 build(deps): bump golang.org/x/net from 0.0.0-20220624214902-1bab6f366d9e to 0.7.0 in /scripts/gen_github_action_config (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3647">#3647</a>)</li> <li>71be32a1 build(deps): bump golang.org/x/net from 0.0.0-20220805013720-a33c5aa5df48 to 0.7.0 in /tools (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3648">#3648</a>)</li> <li>c01eca8a build(deps): bump golang.org/x/oauth2 from 0.5.0 to 0.6.0 in /scripts/gen_github_action_config (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3664">#3664</a>)</li> <li>59f1c6e4 build(deps): bump honnef.co/go/tools from 0.4.2 to 0.4.3 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3699">#3699</a>)</li> <li>55d800ec build(deps): bump sonatype-nexus-community/nancy-github-action from 1.0.2 to 1.0.3 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3665">#3665</a>)</li> <li>6c21f049 chore: fix nancy</li> <li>075691c4 feat: add TeamCity output format (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3606">#3606</a>)</li> <li>985efcc1 feat: check only changed files in pre-commit hook (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3521">#3521</a>)</li> <li>b40a5443 fix: consider path prefix when matching path patterns (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3571">#3571</a>)</li> <li>d7c29985 godox: bump to HEAD (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3697">#3697</a>)</li> <li>610a2bd1 lll: skip go command (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3572">#3572</a>)</li> <li>00c3aa47 rowserrcheck: remove limitation related to generics support (<a href="https://redirect.github.com/golangci/golangci-lint/issues 6377 /3691">#3691</a>)</li> <li>ff50ae4f wastedassign: remove limitation related to generics support (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3689">#3689</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md">github.com/golangci/golangci-lint's changelog</a>.</em></p> <blockquote> <h3>v1.52.0</h3> <ol> <li>updated linters <ul> <li><code>asciicheck</code>: from 0.1.1 to 0.2.0</li> <li><code>bidichk</code>: from 0.2.3 to 0.2.4</li> <li><code>contextcheck</code>: from 1.1.3 to 1.1.4</li> <li><code>dupword</code>: from 0.0.9 to 0.0.11</li> <li><code>durationcheck</code>: from 0.0.9 to 0.0.10</li> <li><code>errchkjson</code>: from 0.3.0 to 0.3.1</li> <li><code>errname</code>: from 0.1.7 to 0.1.9</li> <li><code>forbidigo</code>: from 1.4.0 to 1.5.1</li> <li><code>gci</code>: from 0.9.1 to 0.10.1</li> <li><code>ginkgolinter</code>: from 0.8.1 to 0.9.0</li> <li><code>go-critic</code>: from 0.6.7 to 0.7.0</li> <li><code>go-errorlint</code>: from 1.1.0 to 1.4.0</li> <li><code>godox</code>: bump to HEAD</li> <li><code>lll</code>: skip go command</li> <li><code>loggercheck</code>: from 0.9.3 to 0.9.4</li> <li><code>musttag</code>: from 0.4.5 to 0.5.0</li> <li><code>nilnil</code>: from 0.1.1 to 0.1.3</li> <li><code>noctx</code>: from 0.0.1 to 0.0.2</li> <li><code>revive</code>: from 1.2.5 to 1.3.1</li> <li><code>rowserrcheck</code>: remove limitation related to generics support</li> <li><code>staticcheck</code>: from 0.4.2 to 0.4.3</li> <li><code>testpackage</code>: from 1.1.0 to 1.1.1</li> <li><code>tparallel</code>: from 0.2.1 to 0.3.0</li> <li><code>wastedassign</code>: remove limitation related to generics support</li> <li><code>wrapcheck</code>: from 2.8.0 to 2.8.1</li> </ul> </li> <li>misc. <ul> <li>Add TeamCity output format</li> <li>Consider path prefix when matching path patterns</li> <li>Add Go version to version information</li> </ul> </li> <li>Documentation <ul> <li>Add Tekton in Trusted By page</li> <li>Clarify that custom linters are not enabled by default</li> <li>Remove description for deprecated "go" option</li> </ul> </li> </ol> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint/commit/a12be2d59a0e2d99e1c64efabc55d737f352fc7d"><code>a12be2d</code></a> docs: remove unused from config.LintersSettings (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3704">#3704</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/ca9e2107aee0863175c6cf075019135be0453763"><code>ca9e210</code></a> build(deps): bump github.com/mgechev/revive from 1.3.0 to 1.3.1 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3702">#3702</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/b40a5443b3eddd748e1b1951222edf5b7a4f63b8"><code>b40a544</code></a> fix: consider path prefix when matching path patterns (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3571">#3571</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/e27b129e747fe7564e91b6734225b58558dd6135"><code>e27b129</code></a> build(deps): bump github.com/go-critic/go-critic from 0.6.7 to 0.7.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3701">#3701</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/59f1c6e455a6b288d859662a54707e523a05989d"><code>59f1c6e</code></a> build(deps): bump honnef.co/go/tools from 0.4.2 to 0.4.3 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3699">#3699</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/77d398e612249b29d142d482365732cc16de109e"><code>77d398e</code></a> build(deps): bump github.com/mgechev/revive from 1.2.5 to 1.3.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3698">#3698</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/d7c2998534d086766f9336877809dc1264aee2dc"><code>d7c2998</code></a> godox: bump to HEAD (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3697">#3697</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/a4d2362d68daee4223c1f0c0181b0d1d710f884b"><code>a4d2362</code></a> build(deps): bump github.com/sonatard/noctx from 0.0.1 to 0.0.2 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3696">#3696</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/00c3aa47e4d30fdc7f471f6b54184ff9ee16b1e0"><code>00c3aa4</code></a> rowserrcheck: remove limitation related to generics support (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3691">#3691</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/11c2aed756f0306744f0a1e03f34cf5bc1e97326"><code>11c2aed</code></a> build(deps): bump github.com/tdakkota/asciicheck from 0.1.1 to 0.2.0 (<a href="https://redirect.github.com/golangci/golangci-lint/issues/3694">#3694</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.51.2...v1.52.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/golangci/golangci-lint&package-manager=go_modules&previous-version=1.51.2&new-version=1.52.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.6.0 to 5.6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/go-git/go-git/releases">github.com/go-git/go-git/v5's releases</a>.</em></p> <blockquote> <h2>v5.6.1</h2> <h2>What's Changed</h2> <ul> <li>plumbing/transport: don't use the <code>firstErrLine</code> when it is empty by <a href="https://github.com/ThinkChaos"><code>@ThinkChaos</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/682">go-git/go-git#682</a></li> <li>plumbing/transport: ssh, unable to pass a custom HostKeyCallback func by <a href="https://github.com/aymanbagabas"><code>@aymanbagabas</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/655">go-git/go-git#655</a></li> <li>storage/filesystem: dotgit: fix a filesystem race in Refs/walkReferencesTree by <a href="https://github.com/MichaelMure"><code>@MichaelMure</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/659">go-git/go-git#659</a></li> <li>*: bump golang.org/x/net from 0.2.0 to 0.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/684">go-git/go-git#684</a></li> <li>*: bump dependencies by <a href="https://github.com/pjbgf"><code>@pjbgf</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/697">go-git/go-git#697</a></li> <li>*: fix panic for empty revisions by <a href="https://github.com/pjbgf"><code>@pjbgf</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/696">go-git/go-git#696</a></li> <li>ci: bump GitHub actions, enable go test race detection and stop using developer's GPG keys during test execution by <a href="https://github.com/pjbgf"><code>@pjbgf</code></a> in <a href="https://redirect.github.com/go-git/go-git/pull/701">go-git/go-git#701</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/go-git/go-git/compare/v5.6.0...v5.6.1">https://github.com/go-git/go-git/compare/v5.6.0...v5.6.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/go-git/go-git/commit/3f1cfde283c93f33218c807602e93d47f72f7b90"><code>3f1cfde</code></a> Merge pull request <a href="https://redirect.github.com/go-git/go-git/issues/659">#659</a> from MichaelMure/dotgit-race</li> <li><a href="https://github.com/go-git/go-git/commit/660071d48cfe9728953e4a84960d40deb7078811"><code>660071d</code></a> dotgit: fix deleted references test in windows</li> <li><a href="https://github.com/go-git/go-git/commit/16cc29310be7089bbc8d54d79d608834d2753adc"><code>16cc293</code></a> dotgit: test skip deleted references</li> <li><a href="https://github.com/go-git/go-git/commit/8557a36bc5b1b154c02f6d1deef68fc21f04b128"><code>8557a36</code></a> Merge pull request <a href="https://redirect.github.com/go-git/go-git/issues/655">#655</a> from aymanbagabas/hostkeycallback</li> <li><a href="https://github.com/go-git/go-git/commit/6a70cebb3da9916673a763c0beb716580faa4ff5"><code>6a70ceb</code></a> Merge pull request <a href="https://redirect.github.com/go-git/go-git/issues/701">#701</a> from pjbgf/build</li> <li><a href="https://github.com/go-git/go-git/commit/3ba636d6c9e247882798714e3233930441e0a64e"><code>3ba636d</code></a> fix(ssh): unable to pass a custom HostKeyCallback func</li> <li><a href="https://github.com/go-git/go-git/commit/eddd209ed525a7814ffc80fc2bcd05eb31d0c23a"><code>eddd209</code></a> ci: Enable race detection for go tests</li> <li><a href="https://github.com/go-git/go-git/commit/7368bb92af69a10ca786bfdcbbd52008e3d8395c"><code>7368bb9</code></a> ci: Bump GitHub actions</li> <li><a href="https://github.com/go-git/go-git/commit/fba136de01b6fe8c0530626587c7a1f7f6157563"><code>fba136d</code></a> tests: Avoid use of user's GPG keys during tests</li> <li><a href="https://github.com/go-git/go-git/commit/7e345bb5e163a4badefb0c54da3a057dcde50ed6"><code>7e345bb</code></a> Merge pull request <a href="https://redirect.github.com/go-git/go-git/issues/696">#696</a> from pjbgf/fix-panic-rr</li> <li>Additional commits viewable in <a href="https://github.com/go-git/go-git/compare/v5.6.0...v5.6.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/go-git/go-git/v5&package-manager=go_modules&previous-version=5.6.0&new-version=5.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

* openapi doc fixes and QA docs fixes * rename title Co-authored-by: Thane Thomson <connect@thanethomson.com> * fix text Co-authored-by: Thane Thomson <connect@thanethomson.com> * add backquotes Co-authored-by: Thane Thomson <connect@thanethomson.com> * update contact --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>

* v0.37.x:state/kvindexer: port 0.34 query fix (#77) Backport of #77 from 0.37 and #382 to handle slashes * state/kvindexer: associate event attributes with events (#9759) * By event search is now default behaviour. Including fixes from PRs added to 0.34 --------- Co-authored-by: Lasaro <lasaro@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Sergio Mena <sergio@informal.systems>

* Simplify removeTx and reuse RemoveTxByKey * Do not return errors * Fix lint * Fix error messages * Log error when removing tx

* Add 4 metrics related to block * Remove unused function * Unregister metrics when BlockSync finishes * Add changelog * Rename method * Move method * Do not export unregister method * Do not unregister metrics

…567) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.22.1 to 2.23.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p> <blockquote> <h2>v2.23.1</h2> <h2>Changelog</h2> <ul> <li>a0524f7 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/583">#583</a> from connyay/cjh-config-search-disabled</li> <li>d52c45e Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/584">#584</a> from RangelReale/fixreplacetypefwd</li> <li>04195a5 Move config search disabled message to debug log</li> <li>a515b15 replace type parameter was not being forwarded</li> </ul> <h2>v2.23.0</h2> <h2>Changelog</h2> <ul> <li>ac22d5e Merge branch 'import-customize' of github.com:RangelReale/mockery into import-customize</li> <li>6e9b6a1 Merge branch 'master' into import-customize</li> <li>8e368fa Merge branch 'master' into import-customize</li> <li>e964002 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/540">#540</a> from RangelReale/import-customize</li> <li>c152fc0 README</li> <li>9249785 README</li> <li>66a37ac README</li> <li>9b098fe Update features.md</li> <li>6e2d052 Update features.md</li> <li>17b2136 add replace-type parameter</li> <li>3fdb7f2 add replace-type parameter</li> <li>8ca9a1d cache replace types</li> <li>3862af7 fix parse replace type</li> <li>3dbfebe fix yaml in "layouts" section of docs</li> <li>604a581 flags test</li> <li>fefb94b merge master</li> <li>6bf1f7a rename test</li> <li>36a8f11 reorganization</li> <li>ec95f73 use regexp to test</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vektra/mockery/commit/d52c45e67e740397f13088d0cdff6d0c7054d6c3"><code>d52c45e</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/584">#584</a> from RangelReale/fixreplacetypefwd</li> <li><a href="https://github.com/vektra/mockery/commit/a515b15d257dff2f097ea7ac26782c75d2a64484"><code>a515b15</code></a> replace type parameter was not being forwarded</li> <li><a href="https://github.com/vektra/mockery/commit/a0524f7fdc5e032eab6d0ed792803cbdb9cc665d"><code>a0524f7</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/583">#583</a> from connyay/cjh-config-search-disabled</li> <li><a href="https://github.com/vektra/mockery/commit/04195a52093e8eb9cf53f9cf7fddc73522e9550a"><code>04195a5</code></a> Move config search disabled message to debug log</li> <li><a href="https://github.com/vektra/mockery/commit/e964002a9646fc39c4327fe8a383cf8a0811d2d6"><code>e964002</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/540">#540</a> from RangelReale/import-customize</li> <li><a href="https://github.com/vektra/mockery/commit/3dbfebe17e34f00ad18df4381df72d5b7a231562"><code>3dbfebe</code></a> fix yaml in "layouts" section of docs</li> <li><a href="https://github.com/vektra/mockery/commit/6e2d052ef6a13f6257cb666f2b11717c43153870"><code>6e2d052</code></a> Update features.md</li> <li><a href="https://github.com/vektra/mockery/commit/9b098fe8d8103d508351aa1cb5e0ff78b2b99f9a"><code>9b098fe</code></a> Update features.md</li> <li><a href="https://github.com/vektra/mockery/commit/ec95f73729c594c211c3c1a6a09916e3d6b09e2f"><code>ec95f73</code></a> use regexp to test</li> <li><a href="https://github.com/vektra/mockery/commit/6bf1f7a929162aeaac4a0cf6429cf75c5d8a3781"><code>6bf1f7a</code></a> rename test</li> <li>Additional commits viewable in <a href="https://github.com/vektra/mockery/compare/v2.22.1...v2.23.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.22.1&new-version=2.23.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

abci/example/kvstore/kvstore.go

rpc/client/main_test.go

state/indexer/sink/psql/backport.go

jmalicevic

My review focused mostly on indexer related things and I am not finding anything that is wrong. I locally did a diff between this branch and main, and don't find anything out of the ordinary.

jmalicevic · 2023-03-23T10:15:48Z

state/indexer/block/kv/kv.go

@@ -49,7 +54,7 @@ func (idx *BlockerIndexer) Has(height int64) (bool, error) {
 // The following is indexed:
 //
 // primary key: encode(block.height | height) => encode(height)
-// FinalizeBlock events: encode(eventType.eventAttr|eventValue|height|finalize_block) => encode(height)
+// FinalizeBlock events: encode(eventType.eventAttr|eventValue|height|finalize_block|eventSeq) => encode(height)


In line 74 below, we now do not distinguish the different types of events and store in our database always the same string finalize_block. This is taking up space and is completely useless. I wonder whether we should, at some point open a PR to alter the indexer to remove this? (It is trivial to remove but we would need to account that previous versions of the indexer stored this typ field so we'd need to parse it)

Can we open an issue with this?
Maybe the time to do it is before v0.38.x is out, this way we don't need to support the legacy "finalize_block"

sergio-mena · 2023-03-23T10:39:26Z

20179ec represents the original merge commit + all subsequent commits of this PR squashed onto the merge commit

sergio-mena and others added 30 commits March 2, 2023 21:03

e2e: fix Makefile to produce commit_hash for builtin (#432)

866bf94

* e2e: fix Makefile to produce commit_hash for builtin * Added changelog * Revert "Added changelog" This reverts commit 6c9a683.

Revert "Update go-built-in.md (#438)" (#470)

754f1ae

This reverts commit 06eeaaa.

Move mempoolIDs back to mempool/ids.go (#467)

24040f5

Reorganize existing guides (#492)

fa98b5e

* Moves all guides to a guids folder * Moves the actual intro to the README.md of the intro folder * Add guides to the guide README.md * Fixing links in docs/README.md

ABCI calls should crash/exit in all cases when the call itself report…

2ab8598

…s and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly

Update README.md (#525)

dea72b6

Co-authored-by: Thane Thomson <connect@thanethomson.com>

fix(readme.md): update the links for guides (#526)

d998a52

* fix(readme.md): update the links for guides install guides; single node quick start guides; * Apply suggestions from code review --------- Co-authored-by: Lasaro <lasaro@gmail.com> Co-authored-by: Lasaro <lasaro@informal.systems>

docs: improve Execute code block (#534)

9c5158a

1. `InitialHeight` is specified twice 2. The contents of `Execute` refer to the parameter `state` not `s`

andynog and others added 5 commits March 20, 2023 17:32

Simplify removing txs in mempool (#477)

7ab2dfb

* Simplify removeTx and reuse RemoveTxByKey * Do not return errors * Fix lint * Fix error messages * Log error when removing tx

Add metrics to BlockSync (#538)

2094603

* Add 4 metrics related to block * Remove unused function * Unregister metrics when BlockSync finishes * Add changelog * Rename method * Move method * Do not export unregister method * Do not unregister metrics

sergio-mena requested review from a team as code owners March 23, 2023 07:50

sergio-mena commented Mar 23, 2023

View reviewed changes

abci/example/kvstore/kvstore.go Show resolved Hide resolved

sergio-mena commented Mar 23, 2023

View reviewed changes

rpc/client/main_test.go Show resolved Hide resolved

sergio-mena mentioned this pull request Mar 23, 2023

ABCI 2.0: Final adjustments #10

Closed

16 tasks

sergio-mena commented Mar 23, 2023

View reviewed changes

state/indexer/sink/psql/backport.go Show resolved Hide resolved

jmalicevic approved these changes Mar 23, 2023

View reviewed changes

jmalicevic reviewed Mar 23, 2023

View reviewed changes

Merge branch main into feature/abci++vef

20179ec

sergio-mena force-pushed the sergio/merge-main-into-abci++vef branch from 9b766ac to 20179ec Compare March 23, 2023 10:38

sergio-mena merged commit 20179ec into feature/abci++vef Mar 23, 2023

sergio-mena deleted the sergio/merge-main-into-abci++vef branch March 23, 2023 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge `main` into `feature/abci++vef` (preparation merge) #568

Merge `main` into `feature/abci++vef` (preparation merge) #568

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Merge main into feature/abci++vef (preparation merge) #568

Merge main into feature/abci++vef (preparation merge) #568

Conversation

Uh oh!

PR checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Merge `main` into `feature/abci++vef` (preparation merge) #568

Merge `main` into `feature/abci++vef` (preparation merge) #568