docs: fix more problems with markdown link check #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
commented
May 7, 2022
MalteHerrmann
commented
May 7, 2022
MalteHerrmann
commented
May 7, 2022
|
thanks @MalteHerrmann, can you fix the few errors from the md link? |
|
The references that now still fail the tests point to files that don't exist in the repo anymore.
I could offer to delete the references from the docs as you probably had a good reason to remove these files from the docs in the first place? |
|
@MalteHerrmann souds good, can you remove the first and second links? For |
|
Alright, that's done. ✌️ |
fedekunze
approved these changes
May 9, 2022
loredanacirstea
added a commit
that referenced
this pull request
May 11, 2022
* main: (24 commits) docs: update hardhat guide (#594) audit(erc20): completeness (#592) fix: readd erc20 migration logic (#588) release: v3.0.1 changelog (#584) release: set v4 upgrade heights (#581) docs: fix more problems with markdown link check (#575) bump(ethermint): v0.15.0 (#580) ci: update mergify config (#579) release: v4 upgrade logic (#555) docs: upgrade deps (#578) docs: upgrade documentation (#572) Correct testnet endpoint URLs (#577) build(deps): bump docker/setup-qemu-action from 1 to 2 (#566) build(deps): bump docker/setup-buildx-action from 1 to 2 (#567) ci(fuzz): add fuzz function for x/incentives/types.SplitGasMeterKey (#573) tests(erc20): add integration tests (#571) build(deps): bump docker/login-action from 1 to 2 (#565) tests(erc20): refactor keeper tests (#561) Use universal cosmos gitpod image as an editing environment (#564) build(deps): bump docker/build-push-action from 2 to 3 (#568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have continued to fix problems with the markdown link checker introduced in #548. Now there should only be actually dead links marked, where I could not find the corresponding resources.
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...