8000 fix: readd erc20 migration logic by fedekunze · Pull Request #588 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: readd erc20 migration logic #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022
Merged

fix: readd erc20 migration logic #588

merged 2 commits into from
May 10, 2022

Conversation

fedekunze
Copy link
Collaborator
@fedekunze fedekunze commented May 10, 2022

Description

Revert #556 (doing it manually since I can't click Revert for some reason)


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

8000
@fedekunze fedekunze added backport/4.0.x PR scheduled for inclusion in the v4.0's next stable release bug Something isn't working labels May 10, 2022
@fedekunze fedekunze marked this pull request as ready for review May 10, 2022 07:46
@fedekunze fedekunze enabled auto-merge (squash) May 10, 2022 07:51
@fedekunze fedekunze merged commit bb6bd7f into main May 10, 2022
@fedekunze fedekunze deleted the redo-migrations branch May 10, 2022 07:52
mergify bot pushed a commit that referenced this pull request May 10, 2022
* fix: readd erc20 migration logic

* changelog

(cherry picked from commit bb6bd7f)
fedekunze added a commit that referenced this pull request May 10, 2022
* fix: readd erc20 migration logic (#588)

* fix: readd erc20 migration logic

* changelog

(cherry picked from commit bb6bd7f)

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@danburck
Copy link
Contributor

@fedekunze how come we had to revert?

loredanacirstea added a commit that referenced this pull request May 11, 2022
* main: (24 commits)
  docs: update hardhat guide (#594)
  audit(erc20): completeness (#592)
  fix: readd erc20 migration logic (#588)
  release: v3.0.1 changelog (#584)
  release: set v4 upgrade heights (#581)
  docs: fix more problems with markdown link check (#575)
  bump(ethermint): v0.15.0 (#580)
  ci: update mergify config (#579)
  release: v4 upgrade logic (#555)
  docs: upgrade deps (#578)
  docs: upgrade documentation (#572)
  Correct testnet endpoint URLs (#577)
  build(deps): bump docker/setup-qemu-action from 1 to 2 (#566)
  build(deps): bump docker/setup-buildx-action from 1 to 2 (#567)
  ci(fuzz): add fuzz function for x/incentives/types.SplitGasMeterKey (#573)
  tests(erc20): add integration tests (#571)
  build(deps): bump docker/login-action from 1 to 2 (#565)
  tests(erc20): refactor keeper tests (#561)
  Use universal cosmos gitpod image as an editing environment (#564)
  build(deps): bump docker/build-push-action from 2 to 3 (#568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.0.x PR scheduled for inclusion in the v4.0's next stable release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0